Repository navigation
fix: store no session hash on a post room's one editor row per person - #884
Merged
josephfusco merged 4 commits intoOct 22, 2026
Merged
Conversation
Contributor
🛝 WordPress PlaygroundsBuilt from a64bd72
|
huzaifaalmesbah
marked this pull request as ready for review
October 21, 2026 17:15
huzaifaalmesbah
requested review from
i-am-chitti and
josephfusco
as code owners
October 21, 2026 17:15
Contributor
|
The following accounts have interacted with this PR and/or linked issues. I will continue to update these lists as activity occurs. Core Committers: Use this line as a base for the props when committing in SVN: To understand the WordPress project's expectations around crediting contributors, please review the Contributor Attribution page in the Core Handbook. Props Bot commandsYou can trigger Props Bot actions by commenting on this PR:
|
Codecov Report❌ Patch coverage is Additional details and impacted files@@ Coverage Diff @@
## main #884 +/- ##
============================================
- Coverage 97.53% 97.51% -0.03%
Complexity 272 272
============================================
Files 30 30
Lines 4388 4392 +4
============================================
+ Hits 4280 4283 +3
- Misses 108 109 +1
Flags with carried forward coverage won't be shown. Click here to find out more. 🚀 New features to boost your workflow:
|
i-am-chitti
reviewed
Oct 21, 2026
josephfusco
added
[Type] Bug
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The exception moves into
wp_presence_session_hash()through a new optional$client_id, as #867 kept its own there, so the REST response and the stored row always agree; a tab's own row in the same post room still gets its hash.Fixes #882
Use of AI Tools
AI assistance: Yes
Tool(s): Claude Code
Model(s): Claude Opus 5.5
Used for: Finding the bug, drafting the fix and its test; reviewed and run locally by me.