feat: tell a second browser from a second tab with a per-room session hash - #815

🛝 WordPress Playgrounds

Built from f9bf712

	Post locks	RTC	Synced patterns	Settings
Single site
Multisite

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 97.09%. Comparing base (1b115a9) to head (f9bf712).

@@             Coverage Diff              @@
##               main     #815      +/-   ##
============================================
+ Coverage     97.08%   97.09%   +0.01%     
- Complexity      269      271       +2     
============================================
  Files            30       30              
  Lines          4354     4370      +16     
============================================
+ Hits           4227     4243      +16     
  Misses          127      127              

The following accounts have interacted with this PR and/or linked issues. I will continue to update these lists as activity occurs. You can also manually ask me to refresh this list by adding the props-bot label.

Core Committers: Use this line as a base for the props when committing in SVN:

Props iamchitti, rejaulalomkhan, joefusco.

To understand the WordPress project's expectations around crediting contributors, please review the Contributor Attribution page in the Core Handbook.

Great implementation Joe. Hashing the session token per room cleanly groups tabs into browsers without leaking replayable tokens across rooms.

Two small suggestions:

1. In \wp_presence_write_row()\ (\plugins/presence-api/includes/presence.php), the \LAST_INSERT_ID()\ case checks whether state changed to distinguish a change (\1) from a timestamp refresh (\2):
   \\sql
   CASE WHEN data <> VALUES(data) OR user_id <> VALUES(user_id) OR expires_gmt <= %s THEN 1 ELSE 2 END
   \
   Now that \session_hash\ is a column representing the client's browser, adding \session_hash <> VALUES(session_hash)\ ensures that a session change with identical data is recognized as a room change rather than a refresh.
2. The branch is currently 5 commits behind \main\ and would benefit from a rebase.

Thanks, you caught the CASE first. Both are in: 103715c adds session_hash to it, and the branch is rebased onto main.