Repository navigation
feat: take an $args array in the presence functions - #789
Conversation
🛝 WordPress PlaygroundsBuilt from 4c3836f
|
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## main #789 +/- ##
============================================
+ Coverage 94.84% 94.91% +0.06%
Complexity 268 268
============================================
Files 29 29
Lines 4058 4107 +49
============================================
+ Hits 3849 3898 +49
Misses 209 209
Flags with carried forward coverage won't be shown. Click here to find out more. 🚀 New features to boost your workflow:
|
…nal arguments onto $args
|
The following accounts have interacted with this PR and/or linked issues. I will continue to update these lists as activity occurs. You can also manually ask me to refresh this list by adding the Core Committers: Use this line as a base for the props when committing in SVN: To understand the WordPress project's expectations around crediting contributors, please review the Contributor Attribution page in the Core Handbook. |
There was a problem hiding this comment.
The positional fallback reads well and every caller moved over. Two edge cases in wp_presence_positional_args() inline, both reproduced against this branch with wp eval-file. One question: wp_get_presence_by_room_prefix() still takes a positional $timeout, and the README shows it that way; is leaving it out deliberate, or should it take $args too before the Trac proposal?
AI-assisted review (Claude Code, Claude Opus 5.5); findings checked by me.
|
Leaving |
josephfusco
added
[Type] Enhancement
This extends #735 to
wp_get_presence()andwp_presence_leave()so the whole API reads one way before the Trac proposal shows it, and leaves the_deprecated_argument()notice and the move of the 283 positional test calls to a follow-up, since the old forms still work here.Related: #735
Use of AI Tools
AI assistance: Yes
Tool(s): Claude Code
Model(s): Claude Opus 5.5
Used for: Assisting with the signature change, the call rewrite and tests.