Repository navigation
perf: trust the presence table's version option and recheck it only after a failed write - #682
Merged
Merged
Conversation
Contributor
🛝 WordPress PlaygroundsBuilt from 260013b
|
josephfusco
marked this pull request as ready for review
September 30, 2026 12:44
Contributor
|
The following accounts have interacted with this PR and/or linked issues. I will continue to update these lists as activity occurs. You can also manually ask me to refresh this list by adding the Core Committers: Use this line as a base for the props when committing in SVN: To understand the WordPress project's expectations around crediting contributors, please review the Contributor Attribution page in the Core Handbook. |
Codecov Report❌ Patch coverage is Additional details and impacted files@@ Coverage Diff @@
## main #682 +/- ##
============================================
- Coverage 94.51% 94.49% -0.02%
Complexity 270 270
============================================
Files 28 28
Lines 3972 3976 +4
============================================
+ Hits 3754 3757 +3
- Misses 218 219 +1
Flags with carried forward coverage won't be shown. Click here to find out more. 🚀 New features to boost your workflow:
|
josephfusco
added
[Area] Database
josephfusco
changed the title
i-am-chitti
pushed a commit
that referenced
this pull request
Sep 30, 2026
…fter a failed write (#682) * perf: trust the presence table's version option and recheck the table on activation * docs: leave the recovery story to wp_presence_provision_site() * fix: forget the table version when a write finds the table gone * test: simulate a missing presence table without a DROP that SQLite rolls back
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
A dropped table is now caught by the first write that fails, not by a check on every admin page, which keeps #235's recovery free per request and makes gutenberg-sync-engines fall back to its own store right away.
Related: #344
Use of AI Tools
AI assistance: Yes
Tool(s): Claude Code
Model(s): Claude Opus 5.5
Used for: Assisting with the table check and its recovery path.