Repository navigation
feat: refresh the Editors column on each heartbeat - #606
Conversation
50f7b26 to
ab89bb3
Compare
🛝 WordPress PlaygroundsBuilt from 35d84d3
|
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## main #606 +/- ##
============================================
+ Coverage 95.33% 95.35% +0.02%
Complexity 191 191
============================================
Files 24 24
Lines 3107 3121 +14
============================================
+ Hits 2962 2976 +14
Misses 145 145
Flags with carried forward coverage won't be shown. Click here to find out more. 🚀 New features to boost your workflow:
|
|
The following accounts have interacted with this PR and/or linked issues. I will continue to update these lists as activity occurs. You can also manually ask me to refresh this list by adding the Core Committers: Use this line as a base for the props when committing in SVN: To understand the WordPress project's expectations around crediting contributors, please review the Contributor Attribution page in the Core Handbook. |
There was a problem hiding this comment.
Copilot review overview
🟡 Changes recommended
Address the follower-tab refresh gap, limit presence work to requested posts, and reject unauthorized requests early.
Review effort: Lite
Findings: 2
Open (2)
What changed in this PR
Adds heartbeat-driven refreshes for the post-list Editors column, including UI-enabled non-public post types.
Changes:
- Adds server-side Heartbeat responses and client-side cell updates.
- Refactors editor-stack rendering.
- Updates post-type registration and tests.
| File | Summary |
|---|---|
tests/test-post-list.php |
Tests post-type registration and Heartbeat behavior. |
includes/post-list.php |
Generates editor cells and Heartbeat responses; needs narrower presence queries and early capability checks. |
includes/default-filters.php |
Registers the Heartbeat handler. |
assets/js/presence-ping.js |
Replaces Editors cells; follower tabs need the presence-editors key relayed. |
💡 Add a code-review agent skill or configure MCP servers for context-aware, tailored reviews. Learn more in the docs.
josephfusco
added
[Area] Admin UI
The cells ride on the post IDs core's inline-edit-post.js already sends every tick for its lock icons, so this adds no request; the column now also appears on non-public post types with an admin screen, which may surprise a site that opted one in to presence without wanting it.
Use of AI Tools
AI assistance: Yes
Tool(s): Claude Code
Model(s): Claude Opus 5.5
Used for: Assisting with the heartbeat handler, client swap and tests.