Skip to content

fix: request a retina-sharp avatar resolution and bookend the Who's Online row - #481

Merged
josephfusco merged 4 commits into
mainfrom
fix/retina-avatar-sizes
Sep 9, 2026
Merged

fix: request a retina-sharp avatar resolution and bookend the Who's Online row#481
josephfusco merged 4 commits into
mainfrom
fix/retina-avatar-sizes

Conversation

@josephfusco

@josephfusco josephfusco commented Sep 9, 2026 •
edited
Loading

Copy link
Copy Markdown
Collaborator

Fixes #479
Fixes #480

Use of AI Tools

AI assistance: Yes
Tool(s): Claude Code
Model(s): Sonnet 5
Used for: Assisting with locating every call site and the size/display mismatch, and measuring the row's alignment.

@github-actions

github-actions Bot commented Sep 9, 2026 •
edited
Loading

Copy link
Copy Markdown
Contributor

The following accounts have interacted with this PR and/or linked issues. I will continue to update these lists as activity occurs. You can also manually ask me to refresh this list by adding the props-bot label.

Core Committers: Use this line as a base for the props when committing in SVN:

Props iamchitti, joefusco.

To understand the WordPress project's expectations around crediting contributors, please review the Contributor Attribution page in the Core Handbook.

@josephfusco josephfusco added [Type] Bug An existing feature is broken [Area] Widgets Issues for the dashboard widgets [Area] Admin UI Issues for the admin UI integrations php Pull requests that update php code labels Sep 9, 2026
@github-actions

github-actions Bot commented Sep 9, 2026 •
edited
Loading

Copy link
Copy Markdown
Contributor

🛝 WordPress Playgrounds

Built from f49678c

5 users 40 users
Single site Launch single site, 5 users Launch single site, 40 users
Multisite Launch multisite, 5 users Launch multisite, 40 users

@codecov

codecov Bot commented Sep 9, 2026 •
edited
Loading

Copy link
Copy Markdown

Codecov Report

❌ Patch coverage is 90.00000% with 1 line in your changes missing coverage. Please review.
✅ Project coverage is 95.92%. Comparing base (eddb064) to head (f49678c).

Additional details and impacted files 
@@             Coverage Diff              @@
##               main     #481      +/-   ##
============================================
- Coverage     95.96%   95.92%   -0.04%     
  Complexity      255      255              
============================================
  Files            21       21              
  Lines          3070     3071       +1     
============================================
  Hits           2946     2946              
- Misses          124      125       +1
Flag Coverage Δ
multisite 95.92% <90.00%> (-0.04%) ⬇️
phpunit 71.11% <80.00%> (-0.03%) ⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
  • 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

@josephfusco josephfusco added this to the 0.5.0 milestone Sep 9, 2026
@josephfusco josephfusco changed the title fix: request a retina-sharp avatar resolution across the presence surfaces fix: request a retina-sharp avatar resolution and bookend the Who's Online row Sep 9, 2026
@josephfusco josephfusco added the [Type] Enhancement A suggestion for improvement of an existing feature label Sep 9, 2026
@josephfusco josephfusco mentioned this pull request Sep 9, 2026
Closed
github-actions Bot added a commit that referenced this pull request Sep 9, 2026
@github-actions
Playground preview for PR #481 at f9bdcbb
3c7092c
i-am-chitti
i-am-chitti approved these changes Sep 9, 2026
View reviewed changes

@i-am-chitti i-am-chitti left a comment

Copy link
Copy Markdown
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM ✅

Should a tiny helper be added (e.g. wp_presence_get_avatar_fetch_size( $display_size ) - { $display_size * 2 }) instead of picking each size by value? Could also let each surface fetch its actual 2x (32/40/48 for 16/20/24px) rather than a flat 48 everywhere. Not a blocker, can come as follow-up.

@josephfusco

josephfusco commented Sep 9, 2026

Copy link
Copy Markdown
Collaborator Author

@i-am-chitti Good call out. Will update this PR

github-actions Bot added a commit that referenced this pull request Sep 9, 2026
@github-actions
Playground preview for PR #481 at bcea746
cbf9289
github-actions Bot added a commit that referenced this pull request Sep 9, 2026
@github-actions
Playground preview for PR #481 at f49678c
57d4620
i-am-chitti
i-am-chitti approved these changes Sep 9, 2026
View reviewed changes

@i-am-chitti i-am-chitti left a comment

Copy link
Copy Markdown
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Good to merge 🚀

@josephfusco
josephfusco merged commit a1c3c28 into main Sep 9, 2026
22 checks passed
@josephfusco
josephfusco deleted the fix/retina-avatar-sizes branch September 9, 2026 18:52
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@i-am-chitti i-am-chitti i-am-chitti approved these changes

Assignees

No one assigned

Labels

[Area] Admin UI Issues for the admin UI integrations [Area] Widgets Issues for the dashboard widgets php Pull requests that update php code [Type] Bug An existing feature is broken [Type] Enhancement A suggestion for improvement of an existing feature

Projects

None yet

Milestone

0.5.0

Development

Successfully merging this pull request may close these issues.

Who's Online row avatar doesn't bookend its two-line text block Avatar images are undersized for retina displays across the presence surfaces

2 participants

@josephfusco @i-am-chitti