Output a success message if no errors or warnings are found.#689
Output a success message if no errors or warnings are found.#689davidperezgar merged 5 commits intoWordPress:trunkfrom
Conversation
|
The following accounts have interacted with this PR and/or linked issues. I will continue to update these lists as activity occurs. You can also manually ask me to refresh this list by adding the If you're merging code through a pull request on GitHub, copy and paste the following into the bottom of the merge commit message. To understand the WordPress project's expectations around crediting contributors, please review the Contributor Attribution page in the Core Handbook. |
|
Would you mind updating the Behat tests to cover this new scenario? :-) |
|
@swissspidy I'm just looking at that now. I'm not great with Behat, but I'll try. |
|
@swissspidy OK, the test with There is no existing test for a plugin with no (non-ignored) errors or warnings (i.e., that expects STDOUT to be empty). Would it be helpful to add one? Not sure why some of the tests were "canceled" after the last commit. Can you please restart the tests? |
…the success message.
|
All tests are passing now ;-) |
swissspidy
left a comment
There was a problem hiding this comment.
Looks great to me, thanks!
|
will the plugin-check-action need to be updated? Since I don't use GHA, I don't know if it will fail when the success message is output. |
|
Thanks Paul for the PR! I've requested one change. |
|
Nice! |
fixes #685
When no errors or warnings are found, output a success message with that same text that is used in
Tools > Plugin Check.Before merging this, please verify that producing output on success doesn't cause problems with plugin-check-action.