Upgrade @php-wasm/node to 0.6.16#323
Merged
sejas merged 2 commits intoWordPress:trunkfrom Jul 3, 2024
zaguiini:update/phpwasm-node-0.6.16
Merged
Upgrade @php-wasm/node to 0.6.16#323sejas merged 2 commits intoWordPress:trunkfrom zaguiini:update/phpwasm-node-0.6.16
sejas merged 2 commits intoWordPress:trunkfrom
zaguiini:update/phpwasm-node-0.6.16
Conversation
Member
Author
|
cc @sejas |
sejas
approved these changes
Jul 3, 2024
Collaborator
sejas
left a comment
sejas
left a comment
There was a problem hiding this comment.
I tested wp-now introducing an error and I confirm now the server is still running even with php errors. After fixing the intentional php error, I don't need to restart wp-now.
Screen.Capture.on.2024-07-03.at.22-16-27.mp4
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What?
Bumps
@php-wasm/nodeto the last version before breaking changes.Why?
The main reason I'm bumping this is to catch up with the error handling included in
0.6.13...0.6.16, which improves the developer experience by not crashing the entire process and just reporting the error to the user in the output, allowing them to change the code and refresh the page instead of restarting the server.Testing Instructions
wp-nowwithnode <repo-root>/dist/packages/wp-now/main.js startafter building it locally;