Repository navigation
Conversation
|
The following accounts have interacted with this PR and/or linked issues. I will continue to update these lists as activity occurs. If you're merging code through a pull request on GitHub, copy and paste the following into the bottom of the merge commit message. To understand the WordPress project's expectations around crediting contributors, please review the Contributor Attribution page in the Core Handbook. Props Bot commandsYou can trigger Props Bot actions by commenting on this PR:
|
ekamran
left a comment
ekamran
left a comment
There was a problem hiding this comment.
Tested on a fresh checkout: on master composer lint:errors fails because .cache/ does not exist, and with this PR it passes. The functions.php changes outside the docblock are whitespace only, and the docblock now matches setup_runner_env_vars(). All tracked files are already stored with LF endings, so .gitattributes causes no renormalization diff, and eol=lf makes Windows checkouts use LF too. Thanks @sonali195.
|
Looks good to me. The PHP requirement is read from the cloned WordPress checkout and checked before the build. I found no issues. |
|
Thanks @sonali195. I think this comment was meant for #360, which reads the minimum PHP version from the WordPress checkout before the build. If you meant it as a review of that PR, could you leave it on #360 instead? |
|
Looks good to me. The PHP requirement is read from the cloned WordPress checkout and checked before the build. I found no issues. |
kittenkamala
left a comment
kittenkamala
left a comment
There was a problem hiding this comment.
Hi - will you please separate the formatting/spacing fixes into it's own PR and remove from this one? Thank you!
|
I checked the diff and don’t see any formatting-only changes to separate. The changes appear to be limited to reading WordPress’s PHP requirement and checking it before the build. Could you point me to the formatting or spacing changes you’d like moved? |
| * text=auto eol=lf | ||
|
|
||
| # Explicitly declare text files you want to always be normalized and converted | ||
| # to native line endings on checkout. |
There was a problem hiding this comment.
This comment isn't technically correct, as "native" varies by platform and this is forcing LF endings.
Aside from that, is this file/change needed? This is outside the scope of the PR described purpose of addressing PHPCS cache and typos. Unless there's a need for this file, I would prefer it not be introduced.
I'm not sure if it's the proper approach, and this is a different repo, but wordpress-develop uses the phpcs config to prevent sniff errors related to line endings and has a .editorconfig file.
Description
This pull request provides maintenance improvements for local development and documentation:
PHPCS Cache Directory Tracking:
phpcs.xml.distconfigures<arg name="cache" value=".cache/phpcs.json"/>. On fresh checkouts,.cache/did not exist, causingcomposer lint/phpcsto fail withERROR: The specified cache file path ".cache/phpcs.json" points to a non-existent directory..cache/.gitkeepand updated.gitignore(.cache/*,!.cache/.gitkeep) so the directory is always tracked and available without needing script-level directory guards.Cross-Platform Line Ending Normalization:
.gitattributesto normalize text files to LF (eol=lf), preventing line-ending sniff errors (Generic.Files.LineEndings.InvalidEOLChar) on Windows checkouts.Documentation & Docblock Fixes:
report.php(PHPUnity->PHPUnit).functions.phpforsetup_runner_env_vars()(which previously contained Gutenberg block delimiter descriptions) and updated@type bool $WPT_DEBUG_MODEto$WPT_DEBUG.prepare.php.No core test runner functions or runtime behaviors were modified.
Testing Instructions
composer install.composer lint:errorsto verify all PHPCS checks pass.