Repository navigation
Conversation
|
The following accounts have interacted with this PR and/or linked issues. I will continue to update these lists as activity occurs. You can also manually ask me to refresh this list by adding the If you're merging code through a pull request on GitHub, copy and paste the following into the bottom of the merge commit message. To understand the WordPress project's expectations around crediting contributors, please review the Contributor Attribution page in the Core Handbook. |
|
As implemented, composer lint errors out because it chains two Also the directory guard for the .cache folder is redundant alongside .cache/.gitkeep |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
This pull request addresses several bug fixes, code quality improvements, and compatibility updates across the test runner:
Typo Fixes & Docblock Corrections:
report.php(PHPUnity->PHPUnit).functions.phpforsetup_runner_env_vars()(which previously contained copied Gutenberg block-delimiter descriptions) and corrected@type bool $WPT_DEBUG_MODEto$WPT_DEBUG.prepare.php.PHP 8.1+ Compatibility & Notice Prevention:
wpt_curl_selected_bits()withfunction_exists()checks in bothfunctions.phpandprepare.phpto prevent potential fatal redeclaration errors on repeated calls.shell_exec()outputs before passing totrim()to avoid PHP 8.1+ deprecation warnings when commands returnnull.$version[1]during Imagick/Gmagick version parsing.PHPCS & Cache Improvements:
.cache/.gitkeep, updated.gitignore, and added directory verification incomposer.jsonscripts so runningcomposer lintorphpcsdirectly does not error out on fresh clones when.cache/is missing..gitattributesto enforceeol=lfacross platforms and prevent line-ending sniff errors on Windows checkouts.functions.phpto achieve 0 PHPCS warnings.CI Testing:
8.3to the PHPUnit test workflow matrix (.github/workflows/phpunit-tests.yml).Testing Instructions
composer install.composer lint/composer lint:errorsto verify all PHPCS checks pass.php -lon all PHP files to confirm syntax validity.