Conversation
|
The following accounts have interacted with this PR and/or linked issues. I will continue to update these lists as activity occurs. You can also manually ask me to refresh this list by adding the If you're merging code through a pull request on GitHub, copy and paste the following into the bottom of the merge commit message. To understand the WordPress project's expectations around crediting contributors, please review the Contributor Attribution page in the Core Handbook. |
There was a problem hiding this comment.
@aaronjorbin Thanks! Glad it passes! Do you think there's a reason to keep 8.4 if 8.5 is passing? Is there a scenario where 8.5 would pass and 8.4 would not?
It's a FOSS repo, and the CI minutes are free, so I'd suggest we test against every PHP version we support. Any new 8.5 feature has the possibility to cause 8.4 to fail if not properly gated, for example if we use property overrides to gate |
|
While I think it's unlikely that something would pass on 8.5 and fail on 8.4, testing helps ensure that if there is an issue, it gets caught early. I think in most cases if it passes on 8.5 and fails on 8.4, it will also fail on 8.0. The most likely scenarios I can think of are either miscoded polyfills or bugs in version detection/gating. While there is no monetary cost, enterprises are limited to 500 concurent actions. I don't think that is something we need to worry about here since these are so quick right now, but is something to keep in mind. |
JasonTheAdams
left a comment
There was a problem hiding this comment.
Sounds good! Certainly not a big deal. Thanks for adding this!
Fixes #198