Skip to content

Implement migration logic and UI from Performance Lab modules to their standalone plugins #899

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
swissspidy merged 15 commits into from
Dec 18, 2023
Merged

Implement migration logic and UI from Performance Lab modules to their standalone plugins #899

Changes from 1 commit
Commits
Show all changes
15 commits
Select commit Hold shift + click to select a range
b7bed42
Issue 652 POC/WIP.
10upsimon Nov 30, 2023
3066022
Fix PHPStan
mukeshpanchal27 Dec 11, 2023
517d445
Merge branch 'feature/creating-standalone-plugins' into wip/652
mukeshpanchal27 Dec 11, 2023
db62070
Add inline CSS in admin head
mukeshpanchal27 Dec 13, 2023
bb71b49
Display admin notice in settings page
mukeshpanchal27 Dec 13, 2023
e45cc8e
Address review feedback
mukeshpanchal27 Dec 13, 2023
5fed202
Apply suggestions from code review
mukeshpanchal27 Dec 14, 2023
0dd30f3
Address review feedback
mukeshpanchal27 Dec 14, 2023
abfc2f3
Remove client side validation
mukeshpanchal27 Dec 14, 2023
950dfca
Apply suggestions from code review
mukeshpanchal27 Dec 15, 2023
388be6a
Remove prompt
mukeshpanchal27 Dec 15, 2023
b1c7633
Fix JS lint
mukeshpanchal27 Dec 15, 2023
84e4d93
Address review feedback
mukeshpanchal27 Dec 18, 2023
2bd591d
Use relative path in activate_plugin
mukeshpanchal27 Dec 18, 2023
3e0256c
Add decoding of the HTML entities in PHP
mukeshpanchal27 Dec 18, 2023
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Prev Previous commit
Next Next commit
Add inline CSS in admin head
  • Loading branch information
@mukeshpanchal27
mukeshpanchal27 committed Dec 13, 2023
commit db620701cbf4ec6a1e1ec4bb10f042a232e7c382
4 changes: 2 additions & 2 deletions admin/load.php
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -57,7 +57,7 @@ function perflab_load_modules_page( $modules = null, $focus_areas = null ) {
add_action( 'admin_enqueue_scripts', 'perflab_enqueue_modules_page_scripts' );

// Handle style for settings page.
add_action( 'admin_footer', 'perflab_enqueue_modules_page_style' );
add_action( 'admin_head', 'perflab_print_modules_page_style' );

// Register sections for all focus areas, plus 'Other'.
if ( ! is_array( $focus_areas ) ) {
Expand Down Expand Up @@ -748,7 +748,7 @@ function is_plugin_installed( $plugin_slug ) {
*
* @since n.e.x.t
*/
function perflab_enqueue_modules_page_style() {
function perflab_print_modules_page_style() {
?>
<style type="text/css">
.perflab-button-wrapper {
Expand Down