Skip to content

Add support for plugin live preview in the plugin directory #890

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Nov 30, 2023
Merged

Add support for plugin live preview in the plugin directory #890

merged 1 commit into from
Nov 30, 2023

Conversation

@mukeshpanchal27
Copy link
Member

@mukeshpanchal27 mukeshpanchal27 commented Nov 30, 2023 •
edited
Loading

Summary

Fixes #885

The PR enable live preview support for Performance lab plugin. I can't added the support for standalone plugin because they don't have any settings page.

Note: When we implemented site health related checks in modules then they it will be automatically disable in Playground environment.

Relevant technical choices

Checklist

  • PR has either [Focus] or Infrastructure label.
  • PR has a [Type] label.
  • PR has a milestone or the no milestone label.

@mukeshpanchal27 mukeshpanchal27 added [Type] Enhancement A suggestion for improvement of an existing feature no milestone PRs that do not have a defined milestone for release Miscellaneous Issues not related to an existing focus area labels Nov 30, 2023
@mukeshpanchal27 mukeshpanchal27 self-assigned this Nov 30, 2023
@mukeshpanchal27 mukeshpanchal27 added the Infrastructure Issues for the overall performance plugin infrastructure label Nov 30, 2023
@mukeshpanchal27
Copy link
Member Author

mukeshpanchal27 commented Nov 30, 2023

I've added the Infrastructure label, so the Check Milestone workflow to pass successfully.

felixarntz
felixarntz reviewed Nov 30, 2023
View reviewed changes
Copy link
Member

@felixarntz felixarntz left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks @mukeshpanchal27, this looks solid.

I only have one question - not sure whether this is required or not, so let's clarify that first.

@felixarntz felixarntz changed the title Add Plugin Preview Support in the .org Plugin Directory Add support for plugin live preview in the plugin directory Nov 30, 2023
@felixarntz felixarntz added this to the PL Plugin 2.8.0 milestone Nov 30, 2023
@felixarntz felixarntz removed the no milestone PRs that do not have a defined milestone for release label Nov 30, 2023
@swissspidy swissspidy merged commit 5d77bb0 into trunk Nov 30, 2023
@swissspidy swissspidy deleted the fix/885-add-plugin-preview-support branch November 30, 2023 20:11
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@swissspidy swissspidy swissspidy approved these changes

@felixarntz felixarntz felixarntz approved these changes

@joemcgill joemcgill Awaiting requested review from joemcgill

Assignees

@mukeshpanchal27 mukeshpanchal27

Labels

Infrastructure Issues for the overall performance plugin infrastructure Miscellaneous Issues not related to an existing focus area [Type] Enhancement A suggestion for improvement of an existing feature

Projects

None yet

Milestone

PL Plugin 2.8.0

Development

Successfully merging this pull request may close these issues.

Support Plugin Previews in the .org Plugin Directory

4 participants

@mukeshpanchal27 @swissspidy @felixarntz