Skip to content

Update / PHP Stan Memory Limit#761

Merged
swissspidy merged 2 commits intotrunkfrom
update/php-stan-memory-limit
Jun 20, 2023
Merged

Update / PHP Stan Memory Limit#761
swissspidy merged 2 commits intotrunkfrom
update/php-stan-memory-limit

Conversation

@10upsimon
Copy link
Copy Markdown
Contributor

@10upsimon 10upsimon commented Jun 20, 2023 •
edited
Loading

Summary

  • Increases the memory limit to 2G (2048M) for the phpstan composer command.

Relevant technical choices

  • Appended the --memory-limit=2048M to the existing phpstan composer command to ensure that phpstan runs with enough memory resources due to internal cases of failures when using 512M and even 1024M at times.
  • Referenced other projects (as pointed out by @spacedmonkey ) where this is a common default value, such as that used in Google for Creators - Web Stories (see here).

Props

@mukeshpanchal27 @spacedmonkey

Checklist

  • PR has either [Focus] or Infrastructure label.
  • PR has a [Type] label.
  • PR has a milestone or the no milestone label.

@10upsimon 10upsimon added [Type] Enhancement A suggestion for improvement of an existing feature Infrastructure Issues for the overall performance plugin infrastructure no milestone PRs that do not have a defined milestone for release labels Jun 20, 2023
spacedmonkey
spacedmonkey approved these changes Jun 20, 2023
View reviewed changes
Copy link
Copy Markdown
Member

@spacedmonkey spacedmonkey left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@swissspidy swissspidy merged commit 2816ea5 into trunk Jun 20, 2023
@swissspidy swissspidy deleted the update/php-stan-memory-limit branch June 20, 2023 11:07
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@spacedmonkey spacedmonkey spacedmonkey approved these changes

@swissspidy swissspidy swissspidy approved these changes

@felixarntz felixarntz Awaiting requested review from felixarntz

@mukeshpanchal27 mukeshpanchal27 Awaiting requested review from mukeshpanchal27

Assignees

No one assigned

Labels

Infrastructure Issues for the overall performance plugin infrastructure no milestone PRs that do not have a defined milestone for release [Type] Enhancement A suggestion for improvement of an existing feature

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

3 participants

@10upsimon @spacedmonkey @swissspidy