Add dominant color styling before any existing inline style attributes #716
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
mukeshpanchal27
added
[Type] Bug
Comment on lines
62
to
64
| if ( empty( $attr['style'] ) ) { | ||
| $attr['style'] = ''; | ||
| } |
Member
There was a problem hiding this comment.
Maybe we should get rid of this..
spacedmonkey
requested changes
Apr 20, 2023
Member
spacedmonkey
left a comment
spacedmonkey
left a comment
There was a problem hiding this comment.
Some simple feedback, but otherwise, looking good.
felixarntz
reviewed
Apr 20, 2023
Member
felixarntz
left a comment
felixarntz
left a comment
There was a problem hiding this comment.
@mukeshpanchal27 Almost LGTM, except for what @spacedmonkey already pointed out.
Member
|
@mukeshpanchal27 Since this is a bug fix that has product side implications, we should add a milestone to the issue. |
felixarntz
removed
the
no milestone
Member
|
Nothing additional from me. Thanks for adding a new unit test for this as well! |
Co-authored-by: Jonny Harris <spacedmonkey@users.noreply.github.com>
Member
Author
|
Thanks to all for the feedback. PR is ready for the second round of review. |
pbearne
approved these changes
Apr 21, 2023
spacedmonkey
approved these changes
Apr 21, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
To replicate the issue follow below steps:
Before the patch:
After the patch:
Initially i also think about to use
str_ends_withbut it will create problem when someone add style with space i.e.display: block;then it give false result.Fixes #658
Checklist
[Focus]orInfrastructurelabel.[Type]label.no milestonelabel.