Skip to content

Add perflab_disable_object_cache_dropin filter #629

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
mukeshpanchal27 merged 7 commits into from
Jan 31, 2023
Merged

Add perflab_disable_object_cache_dropin filter #629

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
7 commits
Select commit Hold shift + click to select a range
d588f23
Update load.php
tillkruss Jan 24, 2023
6001808
remove whitespace
tillkruss Jan 24, 2023
ef841af
tweaks
tillkruss Jan 27, 2023
78d83c1
fix @since tag
tillkruss Jan 27, 2023
5c73691
add test case
tillkruss Jan 27, 2023
adcda01
remove whitespace
tillkruss Jan 27, 2023
198dd3a
move test to correct file
tillkruss Jan 27, 2023
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
11 changes: 11 additions & 0 deletions load.php
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -291,6 +291,17 @@ function perflab_maybe_set_object_cache_dropin() {
return;
}

/**
* Filters whether the Perflab server timing drop-in should be set.
*
* @since n.e.x.t
*
* @param bool Whether the server timing drop-in should be set.
*/
if ( apply_filters( 'perflab_disable_object_cache_dropin', false ) ) {
return;
}

// Bail if already attempted before timeout has been completed.
// This is present in case placing the file fails for some reason, to avoid
// excessively retrying to place it on every request.
Expand Down
17 changes: 17 additions & 0 deletions tests/load-tests.php
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -343,6 +343,23 @@ public function test_perflab_maybe_set_object_cache_dropin_with_conflict_and_ori
$this->assertSame( $dummy_file_content2, $wp_filesystem->get_contents( WP_CONTENT_DIR . '/object-cache-plst-orig.php' ) );
}

public function test_perflab_object_cache_dropin_may_be_disabled_via_filter() {
global $wp_filesystem;

$this->set_up_mock_filesystem();

// Ensure PL object-cache.php drop-in is not present and constant is not set.
$this->assertFalse( $wp_filesystem->exists( WP_CONTENT_DIR . '/object-cache.php' ) );
$this->assertFalse( PERFLAB_OBJECT_CACHE_DROPIN_VERSION );

// Add filter to disable drop-in.
add_filter( 'perflab_disable_object_cache_dropin', '__return_true' );

// Run function to place drop-in and ensure it still doesn't exist afterwards.
perflab_maybe_set_object_cache_dropin();
$this->assertFalse( $wp_filesystem->exists( WP_CONTENT_DIR . '/object-cache.php' ) );
}

private function set_up_mock_filesystem() {
global $wp_filesystem;

Expand Down