Skip to content

Remove warning about multi-server environment from the SQLite module description #619

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Jan 9, 2023
Merged

Remove warning about multi-server environment from the SQLite module description #619

merged 1 commit into from
Jan 9, 2023

Conversation

@mukeshpanchal27
Copy link
Member

@mukeshpanchal27 mukeshpanchal27 commented Jan 9, 2023 •
edited by felixarntz
Loading

Summary

Fixes #609

Relevant technical choices

Checklist

  • PR has either [Focus] or Infrastructure label.
  • PR has a [Type] label.
  • PR has a milestone or the no milestone label.

@mukeshpanchal27 mukeshpanchal27 added [Type] Bug An existing feature is broken Needs Review labels Jan 9, 2023
@mukeshpanchal27 mukeshpanchal27 added this to the 1.9.0 milestone Jan 9, 2023
@felixarntz felixarntz changed the title Remove the warning message from the SQLite module description Remove warning about multi-server environment from the SQLite module description Jan 9, 2023
felixarntz
felixarntz approved these changes Jan 9, 2023
View reviewed changes
Copy link
Member

@felixarntz felixarntz left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks @mukeshpanchal27!

@felixarntz felixarntz merged commit a86bcdd into trunk Jan 9, 2023
@felixarntz felixarntz deleted the fix/609-remove-warning-message branch January 9, 2023 19:27
@felixarntz felixarntz added [Type] Enhancement A suggestion for improvement of an existing feature and removed [Type] Bug An existing feature is broken labels Jan 9, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@aristath aristath aristath approved these changes

@felixarntz felixarntz felixarntz approved these changes

@adamsilverstein adamsilverstein Awaiting requested review from adamsilverstein

@JustinyAhin JustinyAhin Awaiting requested review from JustinyAhin

Assignees

No one assigned

Labels

[Type] Enhancement A suggestion for improvement of an existing feature

Projects

None yet

Milestone

1.9.0

Development

Successfully merging this pull request may close these issues.

Clarify language around multi-server environment in SQLite settings

5 participants

@mukeshpanchal27 @aristath @felixarntz @eclarke1