Skip to content

Add an indicator in the adminbar to show when using SQLite #604

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 5 commits into from
Feb 15, 2023
Merged

Add an indicator in the adminbar to show when using SQLite #604

Changes from 1 commit
Commits
Show all changes
5 commits
Select commit Hold shift + click to select a range
81de8b0
Add an indicator in the adminbar to show when using SQLite
aristath Dec 15, 2022
f9a6f42
bail early when not using sqlite
aristath Dec 15, 2022
5dfa9c2
Show whether the db is SQLite or MySQL
aristath Feb 15, 2023
6bf9328
Provide more accurate info about MariaDB vs MySQL, enhance doc block.
felixarntz Feb 15, 2023
05ae841
Further simplify code for readability.
felixarntz Feb 15, 2023
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Next Next commit
Add an indicator in the adminbar to show when using SQLite
  • Loading branch information
@aristath
aristath committed Feb 15, 2023
commit 81de8b066d496d2e6f034bf53e9114c38636f5e7
18 changes: 18 additions & 0 deletions modules/database/sqlite/load.php
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -58,3 +58,21 @@ function perflab_sqlite_plugin_admin_notice() {
);
}
add_action( 'admin_notices', 'perflab_sqlite_plugin_admin_notice' ); // Add the admin notices.

/**
* Add a link to the admin bar.
Copy link
Member

@felixarntz felixarntz Feb 15, 2023

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Function descriptions should start with a third-person verb per WP docs standards. Also, we need to add a @since annotation.

Suggested change
* Add a link to the admin bar.
* Adds a link to the admin bar.
*
* @since n.e.x.t

*
* @param WP_Admin_Bar $admin_bar The admin bar object.
*/
function perflab_sqlite_plugin_adminbar_item( $admin_bar ) {
$args = array(
'id' => 'performance-lab-sqlite',
'parent' => 'top-secondary',
/* translators: %s: SQLite icon. */
'title' => '<span style="color:#46B450;">' . __( 'SQLite activated', 'performance-lab' ) . '</span>',
'href' => esc_url( admin_url( 'options-general.php?page=' . PERFLAB_MODULES_SCREEN ) ),
'meta' => false,
);
$admin_bar->add_node( $args );
}
add_action( 'admin_bar_menu', 'perflab_sqlite_plugin_adminbar_item', 999 );