Skip to content

Fix opt-in checkbox for generating WebP and JPEG to also show on Multisite #565

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
mehulkaklotar merged 5 commits into from
Oct 27, 2022
Merged

Fix opt-in checkbox for generating WebP and JPEG to also show on Multisite #565

Changes from all commits
Commits
Show all changes
5 commits
Select commit Hold shift + click to select a range
5712fa8
#560 - fix multisite setting for generating webp and jpg
mehulkaklotar Oct 20, 2022
c25a0ed
#560 - fix attribute on single site
mehulkaklotar Oct 20, 2022
75e1edc
Update modules/images/webp-uploads/settings.php
mehulkaklotar Oct 26, 2022
a2177b1
#560 fix for tr and td in setting field added for multisite
mehulkaklotar Oct 26, 2022
cb041d1
#560 fix for tr and td in setting field added for multisite
mehulkaklotar Oct 26, 2022
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
23 changes: 15 additions & 8 deletions modules/images/webp-uploads/settings.php
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -33,10 +33,10 @@ function webp_uploads_add_media_settings_field() {
// Add settings field.
add_settings_field(
'perflab_generate_webp_and_jpeg',
__( 'Generate WebP and JPEG', 'performance-lab' ),
__( 'WebP and JPEG', 'performance-lab' ),
'webp_uploads_generate_webp_jpeg_setting_callback',
'media',
'uploads',
is_multisite() ? 'default' : 'uploads',
array( 'class' => 'perflab-generate-webp-and-jpeg' )
);
}
Expand All @@ -48,9 +48,13 @@ function webp_uploads_add_media_settings_field() {
* @since 1.6.0
*/
function webp_uploads_generate_webp_jpeg_setting_callback() {
if ( ! is_multisite() ) {
?>
</td>
<td class="td-full">
<?php
}
?>
</td>
<td class="td-full">
<label for="perflab_generate_webp_and_jpeg">
<input name="perflab_generate_webp_and_jpeg" type="checkbox" id="perflab_generate_webp_and_jpeg" aria-describedby="perflab_generate_webp_and_jpeg_description" value="1"<?php checked( '1', get_option( 'perflab_generate_webp_and_jpeg' ) ); ?> />
<?php esc_html_e( 'Generate JPEG files in addition to WebP', 'performance-lab' ); ?>
Expand All @@ -65,12 +69,15 @@ function webp_uploads_generate_webp_jpeg_setting_callback() {
* @since 1.6.0
*/
function webp_uploads_media_setting_style() {
if ( is_multisite() ) {
return;
}
?>
<style>
.form-table .perflab-generate-webp-and-jpeg th,
.form-table .perflab-generate-webp-and-jpeg td:not(.td-full) {
display: none;
}
.form-table .perflab-generate-webp-and-jpeg th,
.form-table .perflab-generate-webp-and-jpeg td:not(.td-full) {
display: none;
}
</style>
<?php
}
Expand Down