Run tests in different versions of PHP#544
Conversation
|
I thought I'd pick this one up, but a couple of SVG upload tests ( |
|
Thanks @swissspidy for picking. I also don't understood why it going fails 🤔 |
|
So the failures makes sense, because WP doesn't handle/support SVG uploads, so We don't really need to test SVG upload here anyway, so we can just remove it. |
|
Tests on PHP < 7.3 are failing because the PHPUnit version (v9.6) is too new for those PHP versions, causing syntax errors. We probably don't need something as complex as WordPress/plugin-check#321, but definitely something in that direction. |
|
All the unit test pass ✅ now. Looking into integration tests setup. |
|
There is no error output for failing runs, see e.g. https://github.com/WordPress/performance/actions/runs/7650368243/job/20846313421?pr=544 Do we need to log |
|
@swissspidy Added log in script. In local i got below error for PHP 7.2. |
Aah 💡 Now it makes sense. We need to downgrade PHPUnit in this case using Maybe 7d560ae works 🤞 |
|
Or maybe not 🤷 |
| "phpstan": [ | ||
| "composer --working-dir=build-cs update --no-interaction", | ||
| "build-cs/vendor/bin/phpstan analyse --memory-limit=2048M -c phpstan.neon.dist" | ||
| ], | ||
| "format": [ | ||
| "composer --working-dir=build-cs update --no-interaction", | ||
| "build-cs/vendor/bin/phpcbf --standard=phpcs.xml.dist --report-summary --report-source" | ||
| ], | ||
| "lint": [ | ||
| "composer --working-dir=build-cs update --no-interaction", | ||
| "build-cs/vendor/bin/phpcs --standard=phpcs.xml.dist" | ||
| ], |
Summary
Fixes #399
Relevant technical choices
Checklist
[Focus]orInfrastructurelabel.[Type]label.no milestonelabel.