Merged
Conversation
merkys7
added
[Type] Enhancement
merkys7
force-pushed
the
fix/351-phpunit-versions
branch
from
7de1e02 to
7bf8a0e
Compare
Member
|
Thanks for the update. I have some issues with my composer setup. I will check it once it works. @bvdr Can you please review the PR and share your thoughts? |
adamsilverstein
approved these changes
Aug 2, 2022
Member
adamsilverstein
left a comment
adamsilverstein
left a comment
There was a problem hiding this comment.
Looks good, fixed issue in my local testing
mukeshpanchal27
approved these changes
Aug 3, 2022
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Fixes #351
Relevant technical choices
Mentioned PHPUnit error appears when using 8.1 PHP version and PHPUnit 8.5.21 version.
PHPUnit versions are chosen based on the following table: https://make.wordpress.org/core/handbook/references/phpunit-compatibility-and-wordpress-versions/
Different PHP versions require different PHPUnit versions.
The following approach is taken from
WordPress/WordPres-sodium_compathttps://github.com/WordPress/WordPress/blob/f2138f29a83594c60122e6c5416c7a8a4717c519/wp-includes/sodium_compat/composer.json#L57
Checklist
[Focus]orInfrastructurelabel.[Type]label.no milestonelabel.