Skip to content

Ensure incorrect usage of webp_uploads_upload_image_mime_transforms filter is treated correctly #393

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
felixarntz merged 3 commits into from
Jun 23, 2022
Merged

Ensure incorrect usage of webp_uploads_upload_image_mime_transforms filter is treated correctly #393

Changes from 1 commit
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
5b99cf1
fix casting mime transforms to array
jjgrainger Jun 22, 2022
659f03e
add tests for webp_uploads_upload_image_mime_transforms filter
jjgrainger Jun 22, 2022
2787cfc
fix linting errors
jjgrainger Jun 22, 2022
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Next Next commit
fix casting mime transforms to array
  • Loading branch information
@jjgrainger
jjgrainger committed Jun 22, 2022
commit 5b99cf163398a040524c163f52cfb65d8b6076d7
2 changes: 1 addition & 1 deletion modules/images/webp-uploads/helper.php
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -32,7 +32,7 @@ function webp_uploads_get_upload_image_mime_transforms() {
*
* @param array $default_transforms A map with the valid mime transforms.
*/
$transforms = (array) apply_filters( 'webp_uploads_upload_image_mime_transforms', $default_transforms );
$transforms = apply_filters( 'webp_uploads_upload_image_mime_transforms', $default_transforms );

// Return the default mime transforms if a non-array result is returned from the filter.
if ( ! is_array( $transforms ) ) {
Expand Down