Skip to content

Update webp_uploads_pre_generate_additional_image_source filter to allow returning file size #334

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 6 commits into from
Jun 1, 2022
Merged

Update webp_uploads_pre_generate_additional_image_source filter to allow returning file size #334

Changes from 1 commit
Commits
Show all changes
6 commits
Select commit Hold shift + click to select a range
7421a12
Update the webp_uploads_pre_generate_additional_image_source filter t…
eugene-manuilov May 13, 2022
4cfce3c
Update phpunit tests.
eugene-manuilov May 13, 2022
0fc7bb8
Merge remote-tracking branch 'origin/trunk' into enhancement/333-pre-…
eugene-manuilov May 17, 2022
6380957
Address code review feedback.
eugene-manuilov May 17, 2022
a082af9
Fix incorrect test name.
eugene-manuilov May 18, 2022
5a31337
Update tests.
eugene-manuilov May 19, 2022
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Prev Previous commit
Next Next commit
Fix incorrect test name.
  • Loading branch information
@eugene-manuilov
eugene-manuilov committed May 18, 2022
commit a082af9fa85bd7ebf0fdf78894a6da126be16c46
2 changes: 1 addition & 1 deletion tests/modules/images/webp-uploads/helper-tests.php
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -277,7 +277,7 @@ function () {
*
* @test
*/
public function it_should_return_an_error_when_filter_webp_uploads_pre_generate_additional_image_source_returns_filesize() {
public function it_should_use_filesize_when_filter_webp_uploads_pre_generate_additional_image_source_returns_filesize() {
remove_all_filters( 'webp_uploads_pre_generate_additional_image_source' );

add_filter(
Expand Down