Skip to content

Optimization Detective: Include current URL in tag stack mismatch warning - #2712

Open
wprashed wants to merge 3 commits into
WordPress:trunkfrom
wprashed:fix/2622-include-url-in-tag-processor-warning
Open

Optimization Detective: Include current URL in tag stack mismatch warning#2712
wprashed wants to merge 3 commits into
WordPress:trunkfrom
wprashed:fix/2622-include-url-in-tag-processor-warning

Conversation

@wprashed

@wprashed wprashed commented Oct 13, 2026

Copy link
Copy Markdown

Addresses #2622.

Description

When OD_HTML_Tag_Processor encounters a tag stack mismatch caused by unclosed elements in templates, it now includes the current request URL (via od_get_current_url()) in the warning message to make debugging immediately actionable.

@wprashed
wprashed requested a review from westonruter as a code owner October 13, 2026 11:20
@github-actions

github-actions Bot commented Oct 13, 2026

Copy link
Copy Markdown

The following accounts have interacted with this PR and/or linked issues. I will continue to update these lists as activity occurs. You can also manually ask me to refresh this list by adding the props-bot label.

If you're merging code through a pull request on GitHub, copy and paste the following into the bottom of the merge commit message.

Co-authored-by: wprashed <wprashed@git.wordpress.org>

To understand the WordPress project's expectations around crediting contributors, please review the Contributor Attribution page in the Core Handbook.

@github-actions github-actions Bot added the [Plugin] Optimization Detective [slug: optimization-detective] label Oct 13, 2026
@codecov

codecov Bot commented Oct 13, 2026

Copy link
Copy Markdown

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 70.52%. Comparing base (a25f804) to head (36bbb72).
⚠️ Report is 2 commits behind head on trunk.

Additional details and impacted files 
@@            Coverage Diff             @@
##            trunk    #2712      +/-   ##
==========================================
+ Coverage   70.50%   70.52%   +0.01%     
==========================================
  Files          91       91              
  Lines        7869     7874       +5     
==========================================
+ Hits         5548     5553       +5     
  Misses       2321     2321
Flag Coverage Δ
multisite 70.52% <100.00%> (+0.01%) ⬆️
single 35.31% <0.00%> (-0.03%) ⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Harness.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
  • 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

This branch has not been deployed

No deployments
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@westonruter westonruter Awaiting requested review from westonruter westonruter is a code owner

At least 1 approving review is required to merge this pull request.

Assignees

No one assigned

Labels

[Plugin] Optimization Detective [slug: optimization-detective]

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

1 participant

@wprashed