Repository navigation
Conversation
Hi! I'd like to work on this. I'm going to start by adding a PHPUnit test that compares the WebP sub-size dimensions with the JPEG sub-sizes in the metadata, to reproduce the problem. Is this still available?
Fix test formatting for coding standards
github-actions
Bot
added
the
[Plugin] Modern Image Formats
|
The following accounts have interacted with this PR and/or linked issues. I will continue to update these lists as activity occurs. You can also manually ask me to refresh this list by adding the If you're merging code through a pull request on GitHub, copy and paste the following into the bottom of the merge commit message. To understand the WordPress project's expectations around crediting contributors, please review the Contributor Attribution page in the Core Handbook. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Adds a PHPUnit test checking that each WebP sub-size has the same width and height as the matching JPEG sub-size in the attachment metadata, using an image large enough to be scaled.
This adds regression test coverage to ensure dimension consistency between WebP and JPEG sub-sizes.
Relevant technical choices
test_it_should_create_webp_subsizes_with_the_same_dimensions_as_the_jpeg_subsizestest method inplugins/webp-uploads/tests/test-load.php.big_image_size_thresholdset to 850px to ensure scaled sub-sizes are created forleaves.jpg.sizesand verifies the actual dimensions of the generated WebP sub-size files match the expected JPEG sub-size dimensions usingwp_getimagesize().How to test
npm run wp-env-test start.npm run test-php -- --filter test_it_should_create_webp_subsizes_with_the_same_dimensions.Use of AI Tools
I used Claude to help draft the test. I reviewed the implementation, formatted it to WordPress standards, and ran the test suite myself.