Repository navigation
Conversation
Hi! I'd like to work on this. I'm going to start by adding a PHPUnit test that compares the WebP sub-size dimensions with the JPEG sub-sizes in the metadata, to reproduce the problem. Is this still available?
github-actions
Bot
added
the
[Plugin] Modern Image Formats
|
The following accounts have interacted with this PR and/or linked issues. I will continue to update these lists as activity occurs. You can also manually ask me to refresh this list by adding the If you're merging code through a pull request on GitHub, copy and paste the following into the bottom of the merge commit message. To understand the WordPress project's expectations around crediting contributors, please review the Contributor Attribution page in the Core Handbook. |
Fix test formatting for coding standards
mukeshpanchal27
added
[Type] Enhancement
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## trunk #2696 +/- ##
=======================================
Coverage 70.50% 70.50%
=======================================
Files 91 91
Lines 7869 7869
=======================================
Hits 5548 5548
Misses 2321 2321
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Harness. 🚀 New features to boost your workflow:
|
|
Hi @mukeshpanchal27, apologies for the initial confusion! In my first commit ( I restored the original test in commit |
|
Closing in favor of #2704 |
Summary
Adds a PHPUnit test checking that each WebP sub-size has the same width and height as the matching JPEG sub-size in the attachment metadata, using an image large enough to be scaled.
This adds regression test coverage to ensure dimension consistency between WebP and JPEG sub-sizes.
How to test
npm run wp-env-test start.npm run test-php -- --filter test_it_should_create_webp_subsizes_with_the_same_dimensions.Use of AI tools
I used Claude to help draft the test. I reviewed the code, formatted it to WordPress standards, and ran the test suite myself.