Closed
Conversation
felixarntz
reviewed
Mar 28, 2022
Member
felixarntz
left a comment
There was a problem hiding this comment.
@bethanylang Left two comments, mostly this looks good so far.
Would you like to incorporate your suggestions on the WebP Support and Object Cache checks from #229 (comment) into this PR as well? I'd say that would work, and this way it could all be reviewed together. I agree the Enqueued Assets bit should remain separate as it needs more higher-level discussion.
Contributor
Author
|
Requesting to close as I've updated the branch name and submitted a new PR: #272. Sorry for the trouble! |
3 tasks
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Fixes #229.
Checklist
[Focus]orInfrastructurelabel.[Type]label.no milestonelabel.