-
Notifications
You must be signed in to change notification settings - Fork 138
Generate secondary image MIME types when editing original image #235
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Merged
Merged
Changes from 1 commit
Commits
Show all changes
63 commits
Select commit
Hold shift + click to select a range
104cc8d
Convert first file to webp
kirtangajjar 5348eea
Convert image of all size to WebP
kirtangajjar f0ca644
Merge remote-tracking branch 'origin/trunk' into feature/update-secon…
kirtangajjar 436c32d
Add doc comment to function
kirtangajjar e7c3aa1
Skip changes in current mime type
kirtangajjar 5089128
Update modules/images/webp-uploads/load.php
kirtangajjar 3ca1da1
Update modules/images/webp-uploads/load.php
kirtangajjar 1eaa260
Address feedback in comments
kirtangajjar a4185c5
Update doc comment
kirtangajjar fefd06f
Put filter calls right below their corresponding function
kirtangajjar d5e4295
Update modules/images/webp-uploads/load.php
kirtangajjar 2339ac6
Remove redundant logic as per feedback
kirtangajjar 928c37e
Add sources in metadata
kirtangajjar d72617e
Add yoda condition check
kirtangajjar 4f5c0e5
Return override instead of WP_Error
kirtangajjar bc28a85
Ensure there's no error while saving image
kirtangajjar 1e44b9f
Check $mime_type exists in the array before accessing
kirtangajjar 76b6d59
Store only basename of image
kirtangajjar 5956b6e
Make sure the file exists before accessing it
kirtangajjar 9d93713
Change variable name to make it more readable
kirtangajjar 160340e
Add filterable value
kirtangajjar df722d9
Remove commited suggestion
kirtangajjar 47a921a
Fix minor errors from suggestion
kirtangajjar 9a7a97d
Populate top level sources array
kirtangajjar 0158b7c
Update modules/images/webp-uploads/load.php
kirtangajjar d5be5d3
Update modules/images/webp-uploads/load.php
kirtangajjar 94820f9
Fix top level sources metadata not updating
kirtangajjar c6a2ca8
Add WP_Image_Edit testing helper class
kirtangajjar e2d7c5f
Add test for source attribute post editing
kirtangajjar 1aee915
Ignore autogenerated file from PHPCS rule
kirtangajjar 37acfdc
Merge remote-tracking branch 'origin/release/1.0.0-beta.4' into featu…
kirtangajjar 5790b80
Fix PHPCS errors
kirtangajjar 8db0827
Add new assertions to tests
kirtangajjar 93cc08c
Add missing `@since` tag
mitogh 8ebefa8
Add missing override
mitogh 15e07d7
Replace `$override` with plain `null` value instead
mitogh 79dbb80
Merge branch 'release/1.0.0-rc.1' into feature/update-secondary-image…
mitogh 915e281
Merge remote-tracking branch 'origin/release/1.0.0-rc.1' into feature…
kirtangajjar b0aee6d
Add helpers for tests
mitogh 1fbf3c3
Merge branch 'feature/update-secondary-image-onedit' of github.com:Wo…
mitogh 4870e7f
Merge branch 'trunk' into feature/update-secondary-image-onedit
mitogh 54ca7cc
Remove not required empty space
mitogh 9f41f75
Address all the relavant feedback given by reviewers
kirtangajjar eaaa0c1
Merge branch 'feature/update-secondary-image-onedit' of github.com:Wo…
kirtangajjar 2f47f0e
Merge branch 'feature/update-secondary-image-onedit' of github.com:Wo…
mitogh dd5585a
Add empty line.
mitogh 242a575
Add description to the returned value.
mitogh ebb4ce9
Allow to continue the flow in case of a failure
mitogh b101509
Update code following code review feedback
mitogh 1f83396
Use existing transforms as a variable
mitogh 019531a
Use file property
mitogh 7408083
Merge branch 'feature/update-secondary-image-onedit' of github.com:Wo…
mitogh 6d30ccb
Update existing mechanism to generate the edited sources
mitogh b32ee73
Introduce support for target `thumbnail`o
mitogh 4ac0a91
Use the attached image on subsequent image edits
mitogh 96f8ceb
Revert "Use the attached image on subsequent image edits"
mitogh bbc43c7
Revert "Introduce support for target `thumbnail`o"
mitogh 75f1547
Revert "Update existing mechanism to generate the edited sources"
mitogh d71f37f
Update code following the provided feedback
mitogh 063d0ab
Update list of available assertions for edited images
mitogh e4c213e
FIx failing tests and prevent to fail when editing an image
mitogh 2d55d2d
Return $override instead of null for extra safety.
felixarntz 5c829ef
Simplify webp_uploads_update_sources() to not require original file p…
felixarntz File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Add description to the returned value.
Co-authored-by: Felix Arntz <felixarntz@users.noreply.github.com>
- Loading branch information
commit 242a5758bfbd1129cd8892ad746acd14530e2dd4
There are no files selected for viewing
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Uh oh!
There was an error while loading. Please reload this page.