Skip to content

Allow developers to select which image format to use for images in the content #230

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
felixarntz merged 9 commits into from
Mar 18, 2022
Merged

Allow developers to select which image format to use for images in the content #230

Changes from 1 commit
Commits
Show all changes
9 commits
Select commit Hold shift + click to select a range
b7a6e48
Add the webp_uploads_content_image_mimes filter.
eugene-manuilov Mar 14, 2022
e69a2d9
Merge remote-tracking branch 'origin/trunk' into feature/187-content-…
eugene-manuilov Mar 15, 2022
fd86d38
Fix phpunit tests.
eugene-manuilov Mar 15, 2022
a54e89f
Merge remote-tracking branch 'origin/trunk' into feature/187-content-…
eugene-manuilov Mar 17, 2022
baae50f
Update modules/images/webp-uploads/load.php
eugene-manuilov Mar 17, 2022
1edebcf
Merge branch 'feature/187-content-images-format' of github.com:WordPr…
eugene-manuilov Mar 17, 2022
d2103c2
Add additional information to the webp_uploads_content_image_mimes fi…
eugene-manuilov Mar 17, 2022
2c172b2
Add an additional test.
eugene-manuilov Mar 17, 2022
35eb759
Merge remote-tracking branch 'origin/trunk' into feature/187-content-…
eugene-manuilov Mar 17, 2022
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Prev Previous commit
Next Next commit
Add additional information to the webp_uploads_content_image_mimes fi… 
…lter.
  • Loading branch information
@eugene-manuilov
eugene-manuilov committed Mar 17, 2022
commit d2103c23683286059d3d4ee9bd439b0e4069d001
8 changes: 5 additions & 3 deletions modules/images/webp-uploads/load.php
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -560,11 +560,13 @@ function webp_uploads_img_tag_update_mime_type( $image, $context, $attachment_id
*
* @since n.e.x.t
*
* @param array The list of mime types that can be used to update images in the content.
* @param array $target_mimes The list of mime types that can be used to update images in the content.
* @param int $attachment_id The attachment ID.
* @param string $context The current context.
*/
$target_mimes = apply_filters( 'webp_uploads_content_image_mimes', array( 'image/jpeg', 'image/webp' ) );
$target_mimes = apply_filters( 'webp_uploads_content_image_mimes', array( 'image/jpeg', 'image/webp' ), $attachment_id, $context );

$target_mime = null;
$target_mime = null;
// Look for the most progressive image format first.
$target_mimes = array_reverse( $target_mimes );
Comment thread
eugene-manuilov marked this conversation as resolved.
foreach ( $target_mimes as $mime ) {
Comment thread
eugene-manuilov marked this conversation as resolved.
Expand Down