Skip to content

Bump plugin-check to 1.7.0#2257

Closed
westonruter wants to merge 1 commit intotrunkfrom
update/pcp-1.7.0
Closed

Bump plugin-check to 1.7.0#2257
westonruter wants to merge 1 commit intotrunkfrom
update/pcp-1.7.0

Conversation

@westonruter
Copy link
Copy Markdown
Member

@westonruter westonruter commented Nov 7, 2025 •
edited
Loading

This updates plugin-check from 1.6 to 1.7.

However, the update causes a failure:

> phpcs '--' './plugins/performance-lab' '--standard=./plugins/performance-lab/phpcs.xml.dist'
PHP Fatal error:  Uncaught Error: Class "PluginCheckCS\PluginCheck\Helpers\AbstractEscapingCheckSniff" not found in .../wp-content/plugins/performance/vendor/wpackagist-plugin/plugin-check/vendor/plugin-check/phpcs-sniffs/PluginCheck/Sniffs/Security/DirectDBSniff.php:20
Stack trace:
#0 .../wp-content/plugins/performance/vendor/squizlabs/php_codesniffer/autoload.php(173): include()
#1 .../wp-content/plugins/performance/vendor/squizlabs/php_codesniffer/src/Ruleset.php(1401): PHP_CodeSniffer\Autoload::loadFile('/Users/westonru...')
#2 .../wp-content/plugins/performance/vendor/squizlabs/php_codesniffer/src/Ruleset.php(249): PHP_CodeSniffer\Ruleset->registerSniffs(Array, Array, Array)
#3 .../wp-content/plugins/performance/vendor/squizlabs/php_codesniffer/src/Runner.php(348): PHP_CodeSniffer\Ruleset->__construct(Object(PHP_CodeSniffer\Config))
#4 .../wp-content/plugins/performance/vendor/squizlabs/php_codesniffer/src/Runner.php(76): PHP_CodeSniffer\Runner->init()
#5 .../wp-content/plugins/performance/vendor/squizlabs/php_codesniffer/bin/phpcs(14): PHP_CodeSniffer\Runner->runPHPCS()
#6 .../wp-content/plugins/performance/vendor/bin/phpcs(119): include('/Users/westonru...')
#7 {main}
  thrown in .../wp-content/plugins/performance/vendor/wpackagist-plugin/plugin-check/vendor/plugin-check/phpcs-sniffs/PluginCheck/Sniffs/Security/DirectDBSniff.php on line 20

Fatal error: Uncaught Error: Class "PluginCheckCS\PluginCheck\Helpers\AbstractEscapingCheckSniff" not found in .../wp-content/plugins/performance/vendor/wpackagist-plugin/plugin-check/vendor/plugin-check/phpcs-sniffs/PluginCheck/Sniffs/Security/DirectDBSniff.php on line 20

Error: Class "PluginCheckCS\PluginCheck\Helpers\AbstractEscapingCheckSniff" not found in .../wp-content/plugins/performance/vendor/wpackagist-plugin/plugin-check/vendor/plugin-check/phpcs-sniffs/PluginCheck/Sniffs/Security/DirectDBSniff.php on line 20

This needs to be investigated.

@westonruter westonruter added no milestone PRs that do not have a defined milestone for release skip changelog PRs that should not be mentioned in changelogs dependencies Pull requests that update a dependency file labels Nov 7, 2025
@codecov
Copy link
Copy Markdown

codecov bot commented Nov 7, 2025 •
edited
Loading

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 68.86%. Comparing base (7938a41) to head (8f5b802).
⚠️ Report is 155 commits behind head on trunk.

Additional details and impacted files 
@@           Coverage Diff           @@
##            trunk    #2257   +/-   ##
=======================================
  Coverage   68.86%   68.86%           
=======================================
  Files          90       90           
  Lines        7610     7610           
=======================================
  Hits         5241     5241           
  Misses       2369     2369
Flag Coverage Δ
multisite 68.86% <ø> (ø)
single 35.47% <ø> (ø)

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
  • 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

@westonruter westonruter added [Type] Enhancement A suggestion for improvement of an existing feature Needs Dev Anything that requires development (e.g. a pull request) labels Nov 7, 2025
@westonruter westonruter mentioned this pull request Nov 10, 2025
Merged
This was referenced Nov 22, 2025
Closed
Merged
@justlevine justlevine mentioned this pull request Dec 11, 2025
Merged
@westonruter westonruter mentioned this pull request Dec 11, 2025
Open
@westonruter
Copy link
Copy Markdown
Member Author

westonruter commented Jan 2, 2026

The AI Experiments plugin has gone ahead and used the plugin-check GitHub workflow instead: WordPress/ai#139

@westonruter westonruter mentioned this pull request Jan 3, 2026
Merged
4 tasks
mukeshpanchal27
mukeshpanchal27 reviewed Jan 5, 2026
View reviewed changes
composer.json
"phpstan/php-8-stubs": "^0.4.0",
"phpstan/phpstan-strict-rules": "^1.6",
"wpackagist-plugin/plugin-check": "^1.6"
"wpackagist-plugin/plugin-check": "^1.7"
Copy link
Copy Markdown
Member

@mukeshpanchal27 mukeshpanchal27 Jan 5, 2026

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Can we use similar approach that used in WP/AI repo?

Copy link
Copy Markdown
Member Author

@westonruter westonruter Jan 5, 2026

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@mukeshpanchal27 yes, that is what #2320 is for.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@mukeshpanchal27 mukeshpanchal27 mukeshpanchal27 left review comments

Assignees

No one assigned

Labels

dependencies Pull requests that update a dependency file Needs Dev Anything that requires development (e.g. a pull request) no milestone PRs that do not have a defined milestone for release skip changelog PRs that should not be mentioned in changelogs [Type] Enhancement A suggestion for improvement of an existing feature

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

2 participants

@westonruter @mukeshpanchal27