Skip to content

Correct Text Domains in Translatable Strings#2061

Closed
ravigadhiya007 wants to merge 1 commit intoWordPress:trunkfrom
ravigadhiya007:text-domain-issue
Closed

Correct Text Domains in Translatable Strings#2061
ravigadhiya007 wants to merge 1 commit intoWordPress:trunkfrom
ravigadhiya007:text-domain-issue

Conversation

@ravigadhiya007
Copy link
Copy Markdown

Fixes #2060

Relevant technical choices

Updated the text domain in Performance Lab, Embed Optimizer, and Image Placeholders plugins to use the correct text domain based on each plugin’s slug.

@github-actions
Copy link
Copy Markdown

github-actions bot commented Jun 20, 2025

The following accounts have interacted with this PR and/or linked issues. I will continue to update these lists as activity occurs. You can also manually ask me to refresh this list by adding the props-bot label.

If you're merging code through a pull request on GitHub, copy and paste the following into the bottom of the merge commit message.

Co-authored-by: ravigadhiya007 <ravigadhiyawp@git.wordpress.org>
Co-authored-by: mukeshpanchal27 <mukesh27@git.wordpress.org>

To understand the WordPress project's expectations around crediting contributors, please review the Contributor Attribution page in the Core Handbook.

@codecov
Copy link
Copy Markdown

codecov bot commented Jun 20, 2025

Codecov Report

Attention: Patch coverage is 0% with 23 lines in your changes missing coverage. Please review.

Project coverage is 68.03%. Comparing base (ff5cc68) to head (c281bbb).

Files with missing lines Patch % Lines
plugins/performance-lab/includes/admin/plugins.php 0.00% 19 Missing ⚠️
plugins/embed-optimizer/helper.php 0.00% 3 Missing ⚠️
plugins/dominant-color-images/helper.php 0.00% 1 Missing ⚠️
Additional details and impacted files
@@           Coverage Diff           @@
##            trunk    #2061   +/-   ##
=======================================
  Coverage   68.03%   68.03%           
=======================================
  Files          92       92           
  Lines        7631     7631           
=======================================
  Hits         5192     5192           
  Misses       2439     2439           
Flag Coverage Δ
multisite 68.03% <0.00%> (ø)
single 37.02% <0.00%> (ø)

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
  • 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

@mukeshpanchal27
Copy link
Copy Markdown
Member

The default text domain is valid for those strings and is intentionally used so that the translations are sourced directly from WordPress core.

Make as closed.

Copy link
Copy Markdown
Member

@mukeshpanchal27 mukeshpanchal27 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hi there, Thanks for the PR.

Check my comment #2061 (comment)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Fix Incorrect Text Domains in Translatable Strings

3 participants