Skip to content

Inform the user if the current theme explicitly supports view transitions with its own configuration, and add a UI control to make overriding that configuration via settings optional #2037

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 9 commits into from
Jul 2, 2025
Merged

Inform the user if the current theme explicitly supports view transitions with its own configuration, and add a UI control to make overriding that configuration via settings optional #2037

Changes from 1 commit
Commits
Show all changes
9 commits
Select commit Hold shift + click to select a range
b83c2e4
Inform the user if the current theme explicitly supports view transit…
felixarntz Jun 5, 2025
c84d24d
Only render the override UI control if relevant.
felixarntz Jun 5, 2025
ad161b0
Merge branch 'trunk' into view-transitions/respect-theme-support
felixarntz Jun 20, 2025
bd381d0
Render new field as checkbox, reusing UI control from WP Admin view t…
felixarntz Jun 20, 2025
acc50fe
Merge branch 'trunk' into view-transitions/respect-theme-support
felixarntz Jun 30, 2025
108c464
Use info notice instead of warning notice.
felixarntz Jun 30, 2025
c103733
Add missing docs for global variables.
felixarntz Jun 30, 2025
2431d7a
Fix typo.
felixarntz Jun 30, 2025
469b8f0
Show separate settings section for admin view transitions controls.
felixarntz Jun 30, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Prev Previous commit
Next Next commit
Only render the override UI control if relevant.
  • Loading branch information
@felixarntz
felixarntz committed Jun 5, 2025
commit c84d24d9abad8bd3bcda14814078e14568e7616a
8 changes: 8 additions & 0 deletions plugins/view-transitions/includes/settings.php
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -242,6 +242,8 @@ function plvt_apply_settings_to_theme_support(): void {
* @access private
*/
function plvt_add_setting_ui(): void {
global $plvt_has_theme_support_with_args;

add_settings_section(
'plvt_view_transitions',
__( 'View Transitions', 'view-transitions' ),
Expand Down Expand Up @@ -301,6 +303,12 @@ static function (): void {
'description' => __( 'Provide the CSS selector to detect the post content element.', 'view-transitions' ),
),
);

// Do not render the checkbox to override if there is no thing to override.
if ( ! $plvt_has_theme_support_with_args ) {
unset( $fields['override_theme_config'] );
}

foreach ( $fields as $slug => $args ) {
add_settings_field(
"plvt_view_transitions_{$slug}",
Expand Down