Skip to content

Inform the user if the current theme explicitly supports view transitions with its own configuration, and add a UI control to make overriding that configuration via settings optional #2037

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 9 commits into from
Jul 2, 2025
Merged

Inform the user if the current theme explicitly supports view transitions with its own configuration, and add a UI control to make overriding that configuration via settings optional #2037

Changes from 1 commit
Commits
Show all changes
9 commits
Select commit Hold shift + click to select a range
b83c2e4
Inform the user if the current theme explicitly supports view transit…
felixarntz Jun 5, 2025
c84d24d
Only render the override UI control if relevant.
felixarntz Jun 5, 2025
ad161b0
Merge branch 'trunk' into view-transitions/respect-theme-support
felixarntz Jun 20, 2025
bd381d0
Render new field as checkbox, reusing UI control from WP Admin view t…
felixarntz Jun 20, 2025
acc50fe
Merge branch 'trunk' into view-transitions/respect-theme-support
felixarntz Jun 30, 2025
108c464
Use info notice instead of warning notice.
felixarntz Jun 30, 2025
c103733
Add missing docs for global variables.
felixarntz Jun 30, 2025
2431d7a
Fix typo.
felixarntz Jun 30, 2025
469b8f0
Show separate settings section for admin view transitions controls.
felixarntz Jun 30, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Prev Previous commit
Next Next commit
Merge branch 'trunk' into view-transitions/respect-theme-support
  • Loading branch information
@felixarntz
felixarntz committed Jun 20, 2025
commit ad161b00f92694456711e1a53bb7b514e3ff2f23
6 changes: 3 additions & 3 deletions plugins/view-transitions/includes/settings.php
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -45,7 +45,7 @@ function plvt_get_view_transition_animation_labels(): array {
* @since 1.0.0
* @see plvt_sanitize_view_transitions_theme_support()
*
* @return array{ override_theme_config: bool, default_transition_animation: non-empty-string, header_selector: non-empty-string, main_selector: non-empty-string, post_title_selector: non-empty-string, post_thumbnail_selector: non-empty-string, post_content_selector: non-empty-string } {
* @return array{ override_theme_config: bool, default_transition_animation: non-empty-string, header_selector: non-empty-string, main_selector: non-empty-string, post_title_selector: non-empty-string, post_thumbnail_selector: non-empty-string, post_content_selector: non-empty-string, enable_admin_transitions: bool } {
* Default setting value.
*
* @type bool $override_theme_config Whether to override the current theme's configuration. Otherwise,
Expand Down Expand Up @@ -77,7 +77,7 @@ function plvt_get_setting_default(): array {
*
* @since 1.0.0
*
* @return array{ override_theme_config: bool, default_transition_animation: non-empty-string, header_selector: non-empty-string, main_selector: non-empty-string, post_title_selector: non-empty-string, post_thumbnail_selector: non-empty-string, post_content_selector: non-empty-string } {
* @return array{ override_theme_config: bool, default_transition_animation: non-empty-string, header_selector: non-empty-string, main_selector: non-empty-string, post_title_selector: non-empty-string, post_thumbnail_selector: non-empty-string, post_content_selector: non-empty-string, enable_admin_transitions: bool } {
* Stored setting value.
*
* @type bool $override_theme_config Whether to override the current theme's configuration. Otherwise,
Expand All @@ -101,7 +101,7 @@ function plvt_get_stored_setting_value(): array {
* @since 1.0.0
*
* @param mixed $input Setting to sanitize.
* @return array{ override_theme_config: bool, default_transition_animation: non-empty-string, header_selector: non-empty-string, main_selector: non-empty-string, post_title_selector: non-empty-string, post_thumbnail_selector: non-empty-string, post_content_selector: non-empty-string } {
* @return array{ override_theme_config: bool, default_transition_animation: non-empty-string, header_selector: non-empty-string, main_selector: non-empty-string, post_title_selector: non-empty-string, post_thumbnail_selector: non-empty-string, post_content_selector: non-empty-string, enable_admin_transitions: bool } {
* Sanitized setting.
*
* @type bool $override_theme_config Whether to override the current theme's configuration. Otherwise,
Expand Down
You are viewing a condensed version of this merge commit. You can view the full changes here.