Skip to content

Bump minimum required WordPress version to 6.6#1683

Merged
joemcgill merged 3 commits intotrunkfrom
fix/1682-bump-minimum-wp-version
Dec 3, 2024
Merged

Bump minimum required WordPress version to 6.6#1683
joemcgill merged 3 commits intotrunkfrom
fix/1682-bump-minimum-wp-version

Conversation

@mukeshpanchal27
Copy link
Copy Markdown
Member

@mukeshpanchal27 mukeshpanchal27 commented Nov 20, 2024

Summary

Fixes #1682

@mukeshpanchal27 mukeshpanchal27 added [Type] Enhancement A suggestion for improvement of an existing feature Infrastructure Issues for the overall performance plugin infrastructure skip changelog PRs that should not be mentioned in changelogs labels Nov 20, 2024
@mukeshpanchal27 mukeshpanchal27 self-assigned this Nov 20, 2024
@mukeshpanchal27 mukeshpanchal27 removed this from the performance-lab n.e.x.t milestone Nov 20, 2024
@mukeshpanchal27 mukeshpanchal27 marked this pull request as ready for review November 20, 2024 14:36
@github-actions
Copy link
Copy Markdown

github-actions bot commented Nov 20, 2024 •
edited
Loading

The following accounts have interacted with this PR and/or linked issues. I will continue to update these lists as activity occurs. You can also manually ask me to refresh this list by adding the props-bot label.

If you're merging code through a pull request on GitHub, copy and paste the following into the bottom of the merge commit message.

Co-authored-by: mukeshpanchal27 <mukesh27@git.wordpress.org>
Co-authored-by: westonruter <westonruter@git.wordpress.org>
Co-authored-by: felixarntz <flixos90@git.wordpress.org>
Co-authored-by: joemcgill <joemcgill@git.wordpress.org>

To understand the WordPress project's expectations around crediting contributors, please review the Contributor Attribution page in the Core Handbook.

felixarntz
felixarntz requested changes Nov 20, 2024
View reviewed changes
Copy link
Copy Markdown
Member

@felixarntz felixarntz left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Per the discussion in #1682, I don't see a good reason to bump the required WordPress version, even less so to 6.6 because the latest release is 6.7.

Let's continue discussion in the issue to determine what we want to do.

@mukeshpanchal27 mukeshpanchal27 mentioned this pull request Dec 2, 2024
Merged
@mukeshpanchal27 mukeshpanchal27 added no milestone PRs that do not have a defined milestone for release and removed blocked no milestone PRs that do not have a defined milestone for release labels Dec 3, 2024
@mukeshpanchal27
Copy link
Copy Markdown
Member Author

mukeshpanchal27 commented Dec 3, 2024

Per #1701 (comment) these one is unblocked and ready for review.

cc. @felixarntz @joemcgill

@mukeshpanchal27 mukeshpanchal27 removed this from the performance-lab n.e.x.t milestone Dec 3, 2024
@mukeshpanchal27 mukeshpanchal27 added the no milestone PRs that do not have a defined milestone for release label Dec 3, 2024
joemcgill
joemcgill approved these changes Dec 3, 2024
View reviewed changes
Copy link
Copy Markdown
Member

@joemcgill joemcgill left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Based on @felixarntz response in #1701 (comment), this seems good now.

@joemcgill joemcgill merged commit 6036183 into trunk Dec 3, 2024
@joemcgill joemcgill deleted the fix/1682-bump-minimum-wp-version branch December 3, 2024 17:23
@mukeshpanchal27 mukeshpanchal27 mentioned this pull request Jul 22, 2025
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@westonruter westonruter westonruter approved these changes

@joemcgill joemcgill joemcgill approved these changes

@felixarntz felixarntz felixarntz approved these changes

@adamsilverstein adamsilverstein Awaiting requested review from adamsilverstein adamsilverstein is a code owner

@pbearne pbearne Awaiting requested review from pbearne

@thelovekesh thelovekesh Awaiting requested review from thelovekesh thelovekesh is a code owner

Assignees

@mukeshpanchal27 mukeshpanchal27

Labels

Infrastructure Issues for the overall performance plugin infrastructure no milestone PRs that do not have a defined milestone for release skip changelog PRs that should not be mentioned in changelogs [Type] Enhancement A suggestion for improvement of an existing feature

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

Bump minimum required WordPress version to 6.6

4 participants

@mukeshpanchal27 @westonruter @joemcgill @felixarntz