Skip to content

Install and activate Optimization Detective when the Embed Optimizer feature is activated from the Performance screen #1644

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
felixarntz merged 3 commits into from
Nov 11, 2024
Merged

Install and activate Optimization Detective when the Embed Optimizer feature is activated from the Performance screen #1644

Changes from all commits
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
7bee476
Install and activate Optimization Detective when the Embed Optimizer …
westonruter Nov 11, 2024
b012d8d
Remove hard-coded reference to embed-optimizer
westonruter Nov 11, 2024
70f90b6
Revert "Remove hard-coded reference to embed-optimizer"
westonruter Nov 11, 2024
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
7 changes: 6 additions & 1 deletion plugins/performance-lab/includes/admin/plugins.php
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -71,7 +71,7 @@ function perflab_query_plugin_info( string $plugin_slug ) {
$plugins = array();
$standalone_plugins = array_merge(
array_flip( perflab_get_standalone_plugins() ),
array( 'optimization-detective' => array() ) // TODO: Programmatically discover the plugin dependencies and add them here.
array( 'optimization-detective' => array() ) // TODO: Programmatically discover the plugin dependencies and add them here. See <https://github.com/WordPress/performance/issues/1616>.
);
foreach ( $response->plugins as $plugin_data ) {
if ( ! isset( $standalone_plugins[ $plugin_data['slug'] ] ) ) {
Expand Down Expand Up @@ -324,6 +324,11 @@ function perflab_install_and_activate_plugin( string $plugin_slug, array &$proce
return $plugin_data;
}

// Add recommended plugins (soft dependencies) to the list of plugins installed and activated.
if ( 'embed-optimizer' === $plugin_slug ) {
$plugin_data['requires_plugins'][] = 'optimization-detective';
}

// Install and activate plugin dependencies first.
foreach ( $plugin_data['requires_plugins'] as $requires_plugin_slug ) {
$result = perflab_install_and_activate_plugin( $requires_plugin_slug );
Expand Down