Skip to content

Add PHPStan strict rules (except for empty.notAllowed) #1241

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 24 commits into from
Jul 23, 2024
Merged

Add PHPStan strict rules (except for empty.notAllowed) #1241

Changes from 1 commit
Commits
Show all changes
24 commits
Select commit Hold shift + click to select a range
94f4f22
Add phpstan-strict-rules
westonruter May 23, 2024
211d192
Ignore staticMethod.dynamicCall, booleanNot.exprNotBoolean, and if.co…
westonruter May 23, 2024
f2c5120
Fix cast.useless
westonruter May 23, 2024
0c5c42b
Fix method.childReturnType
westonruter May 23, 2024
66dd4d6
Fix plus.leftNonNumeric
westonruter May 23, 2024
db11733
Disable strictArrayFilter rule
westonruter May 23, 2024
165b15b
Fix variable.implicitArray
westonruter May 23, 2024
d3e0f22
Fix instance of booleanAnd.leftNotBoolean
westonruter May 23, 2024
db82f1e
Update phpstan to 1.11.4
westonruter Jun 13, 2024
7de2d96
Fix interface.nameCase
westonruter Jun 13, 2024
87ecaad
Fix booleanNot.exprNotBoolean
westonruter Jun 13, 2024
44d8375
Fix ternary.condNotBoolean
westonruter Jun 13, 2024
94884c5
Fix booleanOr.rightNotBoolean
westonruter Jun 13, 2024
5b5cd68
Fix booleanAnd.leftNotBoolean
westonruter Jun 13, 2024
dad5312
Fix if.condNotBoolean
westonruter Jun 13, 2024
228035f
Ignore empty.notAllowed temporarily
westonruter Jun 13, 2024
831105c
Treat a boolean src attribute as if it is an inline script
westonruter Jul 11, 2024
b99c7c0
Merge branch 'trunk' of https://github.com/WordPress/performance into…
westonruter Jul 22, 2024
0413c60
Fix remaining strict rule violations
westonruter Jul 23, 2024
350ddbf
Merge branch 'trunk' of https://github.com/WordPress/performance into…
westonruter Jul 23, 2024
d4af3a6
Fix and improve conditions in auto_sizes_filter_image_tag and add typing
westonruter Jul 23, 2024
8e90f62
Remove unnecessary casting to int
westonruter Jul 23, 2024
4f4f6bd
Remove unnecessary casting
westonruter Jul 23, 2024
eaf1f65
Fix logic inversion
westonruter Jul 23, 2024
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Prev Previous commit
Next Next commit
Ignore empty.notAllowed temporarily
  • Loading branch information
@westonruter
westonruter committed Jun 13, 2024
commit 228035ffa4805976d573d2af8dbdf1f2f4f6de30
3 changes: 3 additions & 0 deletions phpstan.neon.dist
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -62,3 +62,6 @@ parameters:
-
identifier: staticMethod.dynamicCall
Copy link
Member Author

@westonruter westonruter Jun 13, 2024

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I'm not sure why this issue is being reported for assertion method calls in tests.

path: */tests/*
-
# TODO: Remove this to fix https://github.com/WordPress/performance/issues/1219
identifier: empty.notAllowed