Skip to content

Add module to warn about excessive amount of autoloaded options #124

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 14 commits into from
Mar 18, 2022
Merged

Add module to warn about excessive amount of autoloaded options #124

Show file tree
Hide file tree
Changes from 1 commit
Commits
Show all changes
14 commits
Select commit Hold shift + click to select a range
3528dd8
adding autoloaded options check to site health
manuelRod Jan 19, 2022
b5049c0
adding tests
manuelRod Jan 20, 2022
eac9521
moving file
manuelRod Jan 20, 2022
d3f7d52
Merge branch 'trunk' into add/sitehealth-autoloaded-options
manuelRod Jan 20, 2022
74932f8
Adding resource link to actions
manuelRod Jan 24, 2022
11dd3f3
simplify code
manuelRod Feb 8, 2022
be7b17d
some small refactor, + adding better documentation to filters
manuelRod Feb 15, 2022
814bb4a
nitpick
manuelRod Feb 28, 2022
a1ebb71
nitpicks
manuelRod Mar 11, 2022
389a0ff
moving mock response class to dataproviders.
manuelRod Mar 14, 2022
7c6a9f7
updating some comments
manuelRod Mar 15, 2022
b6a1949
simplifying test using wp_generate_password instead of custom random …
manuelRod Mar 16, 2022
f45fc53
Merge branch 'release/1.0.0-beta.2' into add/sitehealth-autoloaded-op…
manuelRod Mar 18, 2022
725bbd4
marking as experimental
manuelRod Mar 18, 2022
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Prev Previous commit
Next Next commit
updating some comments
  • Loading branch information
@manuelRod
manuelRod committed Mar 15, 2022
commit 7c6a9f7f2d1facb77cd3b888dd3efd26b99b070b
8 changes: 4 additions & 4 deletions modules/site-health/audit-autoloaded-options/load.php
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -55,7 +55,7 @@ function perflab_aao_autoloaded_options_test() {
);

/**
* Hostings can modify its limits depending on their own requirements.
* Filters max bytes threshold to trigger warning in Site Health.
*
* @since 1.0.0
*
Expand All @@ -77,11 +77,11 @@ function perflab_aao_autoloaded_options_test() {
);

/**
* Hostings can modify description to be shown on site health screen.
* Filters description to be shown on Site Health warning when threshold is met.
*
* @since 1.0.0
*
* @param string $description Description message when autoloaded options bigger than treshold.
* @param string $description Description message when autoloaded options bigger than threshold.
*/
$result['description'] = apply_filters( 'perflab_aao_autoloaded_options_limit_description', $result['description'] );

Expand All @@ -93,7 +93,7 @@ function perflab_aao_autoloaded_options_test() {
);

/**
* Hostings can add actions to take to reduce size of autoloaded options linking to their own guides.
* Filters actionable information to tackle the problem. It can be a link to an external guide.
*
* @since 1.0.0
*
Expand Down
2 changes: 1 addition & 1 deletion tests/modules/site-health/audit-autoloaded-options/audit-autoloaded-options-test.php
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -96,7 +96,7 @@ protected static function random_string_generator( $length ) {
*
* @return array
*/
function provider_added_test_info_site_health() {
public function provider_added_test_info_site_health() {
$added_tests = array();
$added_tests['direct']['autoloaded_options'] = array(
'label' => esc_html__( 'Autoloaded options', 'performance-lab' ),
Expand Down