Skip to content

Added server timing to REST API response #1206

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 13 commits into from
May 14, 2024
Merged

Added server timing to REST API response #1206

Show file tree
Hide file tree
Changes from 1 commit
Commits
Show all changes
13 commits
Select commit Hold shift + click to select a range
d8584b0
Added server timing to REST API response
ashwinparthasarathi May 7, 2024
94f3c79
Updated code to include a hooks.php file
ashwinparthasarathi May 7, 2024
d806f93
Update includes/server-timing/hooks.php
ashwinparthasarathi May 7, 2024
288cc08
Update includes/server-timing/hooks.php
ashwinparthasarathi May 7, 2024
f695170
Updated code as per review comments
ashwinparthasarathi May 7, 2024
d45bd02
Merge branch 'update/add-server-timing-in-rest-api' of github.com:ash…
ashwinparthasarathi May 7, 2024
6e3a3a7
Update includes/server-timing/hooks.php
ashwinparthasarathi May 7, 2024
c370810
Update includes/server-timing/hooks.php
ashwinparthasarathi May 8, 2024
fe88513
Update includes/server-timing/hooks.php
ashwinparthasarathi May 8, 2024
26c7077
Merge branch 'WordPress:trunk' into update/add-server-timing-in-rest-api
ashwinparthasarathi May 8, 2024
e665159
Changed code based on review comments.
ashwinparthasarathi May 12, 2024
c69b1cd
Merge branch 'trunk' into update/add-server-timing-in-rest-api
westonruter May 13, 2024
82ffc1a
Update includes/server-timing/hooks.php
ashwinparthasarathi May 14, 2024
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Prev Previous commit
Next Next commit
Updated code to include a hooks.php file
  • Loading branch information
@ashwinparthasarathi
ashwinparthasarathi committed May 7, 2024
commit 94f3c79be5522cdf8dca2abee38c10dde71e65d1
38 changes: 38 additions & 0 deletions includes/server-timing/hooks.php
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -0,0 +1,38 @@
<?php
/**
* Hook callbacks used for Server Timing.
*
* @package dominant-color-images
*
* @since 1.0.0
*/

if ( ! defined( 'ABSPATH' ) ) {
exit; // Exit if accessed directly.
}


/**
* Adds server timing to REST API response.
*
* @param WP_REST_Response|WP_Error $response Result to send to the client. Usually a `WP_REST_Response`.
* @return WP_REST_Response|WP_Error Filtered response.
*/
function rest_post_dispatch_add_server_timing( $response ) {
if ( ! defined( 'REST_REQUEST' ) || ! REST_REQUEST ) {
return $response;
}

if ( ! function_exists( 'perflab_server_timing' ) || ! $response instanceof WP_REST_Response ) {
return $response;
}

$server_timing = perflab_server_timing();

do_action( 'perflab_server_timing_send_header' ); // phpcs:ignore WordPress.NamingConventions.PrefixAllGlobals.NonPrefixedHooknameFound

$response->header( 'Server-Timing', $server_timing->get_header() );

return $response;
}
add_filter( 'rest_post_dispatch', 'rest_post_dispatch_add_server_timing' );
28 changes: 2 additions & 26 deletions includes/server-timing/load.php
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -18,6 +18,8 @@
define( 'PERFLAB_SERVER_TIMING_SETTING', 'perflab_server_timing_settings' );
define( 'PERFLAB_SERVER_TIMING_SCREEN', 'perflab-server-timing' );

require_once __DIR__ . '/hooks.php';

/**
* Provides access the Server-Timing API.
*
Expand Down Expand Up @@ -223,29 +225,3 @@ static function ( $hook_name ) {

return $value;
}

/**
* Adds server timing to REST API response.
*
* @param WP_REST_Response|WP_Error $response Result to send to the client. Usually a `WP_REST_Response`.
* @return WP_REST_Response|WP_Error Filtered response.
*/
function rest_post_dispatch_add_server_timing( $response ) {
if ( ! defined( 'REST_REQUEST' ) || ! REST_REQUEST ) {
return $response;
}

if ( ! function_exists( 'perflab_server_timing' ) || ! $response instanceof WP_REST_Response ) {
return $response;
}

$server_timing = perflab_server_timing();

do_action( 'perflab_server_timing_send_header' ); // phpcs:ignore WordPress.NamingConventions.PrefixAllGlobals.NonPrefixedHooknameFound

$response->header( 'Server-Timing', $server_timing->get_header() );

return $response;
}

add_filter( 'rest_post_dispatch', 'rest_post_dispatch_add_server_timing' );