Skip to content

Add Progress indicator when activating a feature #1190

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 5 commits into from
Apr 30, 2024
Merged

Add Progress indicator when activating a feature #1190

merged 5 commits into from
Apr 30, 2024

Conversation

@mukeshpanchal27
Copy link
Member

@mukeshpanchal27 mukeshpanchal27 commented Apr 30, 2024

Summary

Fixes #1139

@mukeshpanchal27 mukeshpanchal27 added [Type] Enhancement A suggestion for improvement of an existing feature no milestone PRs that do not have a defined milestone for release [Plugin] Performance Lab Issue relates to work in the Performance Lab Plugin only labels Apr 30, 2024
@mukeshpanchal27 mukeshpanchal27 self-assigned this Apr 30, 2024
@mukeshpanchal27 mukeshpanchal27 marked this pull request as ready for review April 30, 2024 05:10
@github-actions
Copy link

github-actions bot commented Apr 30, 2024 •
edited
Loading

The following accounts have interacted with this PR and/or linked issues. I will continue to update these lists as activity occurs. You can also manually ask me to refresh this list by adding the props-bot label.

If you're merging code through a pull request on GitHub, copy and paste the following into the bottom of the merge commit message.

Co-authored-by: mukeshpanchal27 <mukesh27@git.wordpress.org>
Co-authored-by: westonruter <westonruter@git.wordpress.org>
Co-authored-by: swissspidy <swissspidy@git.wordpress.org>

To understand the WordPress project's expectations around crediting contributors, please review the Contributor Attribution page in the Core Handbook.

westonruter
westonruter requested changes Apr 30, 2024
View reviewed changes
Copy link
Member

@westonruter westonruter left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Wow, so nice!

Screen.recording.2024-04-29.22.15.19.webm

@westonruter
Copy link
Member

westonruter commented Apr 30, 2024

@mukeshpanchal27 this works in WP 6.4 as well, yes?

swissspidy
swissspidy reviewed Apr 30, 2024
View reviewed changes
@mukeshpanchal27
Copy link
Member Author

mukeshpanchal27 commented Apr 30, 2024

@mukeshpanchal27 this works in WP 6.4 as well, yes?

Yes, it works fine in 6.4.

swissspidy
swissspidy reviewed Apr 30, 2024
View reviewed changes
@swissspidy swissspidy merged commit 1bf56c9 into trunk Apr 30, 2024
@swissspidy swissspidy deleted the fix/1139-add-progress-indicator branch April 30, 2024 12:10
@swissspidy swissspidy added this to the performance-lab 3.1.0 milestone Apr 30, 2024
@mukeshpanchal27 mukeshpanchal27 removed the no milestone PRs that do not have a defined milestone for release label Apr 30, 2024
westonruter
westonruter reviewed Apr 30, 2024
View reviewed changes
includes/admin/load.php
sprintf(
'( %s )( %s );',
$js_function,
wp_json_encode( __( 'Activating…', 'default' ) )
Copy link
Member

@westonruter westonruter Apr 30, 2024 •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I just realized that this is 'Activating…' when the core string appears to rather be 'Activating...' (not using the ellipsis):

https://github.com/WordPress/wordpress-develop/blob/f9e5c6fb22a331746a1821e393c9ea6a6e6d70a0/src/js/_enqueues/wp/updates.js#L1090

Does this need to be amended?

westonruter
westonruter reviewed Apr 30, 2024
View reviewed changes
includes/admin/load.php
target.classList.add( 'updating-message' );
target.textContent = message;
wp.a11y.speak(message);
Copy link
Member

@westonruter westonruter Apr 30, 2024

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nit: Add spacing around the message param

westonruter
westonruter reviewed Apr 30, 2024
View reviewed changes
includes/admin/load.php
*
* @since n.e.x.t
*/
function perflab_print_plugin_progress_indicator_script() {
Copy link
Member

@westonruter westonruter Apr 30, 2024

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Also, per #1188, might as well explicitly make this return void:

function perflab_print_plugin_progress_indicator_script(): void {

@mukeshpanchal27 mukeshpanchal27 mentioned this pull request May 1, 2024
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@westonruter westonruter westonruter approved these changes

@swissspidy swissspidy swissspidy approved these changes

@joemcgill joemcgill Awaiting requested review from joemcgill

@thelovekesh thelovekesh Awaiting requested review from thelovekesh

Assignees

@mukeshpanchal27 mukeshpanchal27

Labels

[Plugin] Performance Lab Issue relates to work in the Performance Lab Plugin only [Type] Enhancement A suggestion for improvement of an existing feature

Projects

None yet

Milestone

performance-lab 3.1.0

Development

Successfully merging this pull request may close these issues.

Progress indicator is missing when activating a feature

4 participants

@mukeshpanchal27 @westonruter @swissspidy