Skip to content

Do not show admin pointer on the Performance screen and dismiss the pointer when visited #1147

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 12 commits into from
Apr 19, 2024
Merged

Do not show admin pointer on the Performance screen and dismiss the pointer when visited #1147

Changes from 4 commits
Commits
Show all changes
12 commits
Select commit Hold shift + click to select a range
6c1fced
Do not show on the settings page and dismiss the pointer
Ellusu Apr 16, 2024
587f706
Update includes/admin/load.php
Ellusu Apr 16, 2024
3809b71
Update includes/admin/load.php
Ellusu Apr 16, 2024
e381c65
Update includes/admin/load.php
Ellusu Apr 16, 2024
15eb800
Update includes/admin/load.php
Ellusu Apr 17, 2024
b46427f
Update load.php
Ellusu Apr 17, 2024
28f8732
Update load.php
Ellusu Apr 17, 2024
f0adcb1
Update load.php
Ellusu Apr 17, 2024
3f1f6cc
Update includes/admin/load.php
Ellusu Apr 17, 2024
59b9095
optimize order of return controller
Ellusu Apr 18, 2024
f2c8c8d
php lind error fix
Ellusu Apr 18, 2024
73297b6
Update load.php
Ellusu Apr 18, 2024
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
12 changes: 10 additions & 2 deletions includes/admin/load.php
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -77,7 +77,16 @@ function perflab_render_settings_page() {
* @param string $hook_suffix The current admin page.
*/
function perflab_admin_pointer( $hook_suffix ) {
$current_user = get_current_user_id();

if ( ! in_array( $hook_suffix, array( 'index.php', 'plugins.php' ), true ) ) {

// Do not show on the settings page and dismiss the pointer.
if ( ! empty( $_GET['page'] ) && PERFLAB_SCREEN === $_GET['page'] ) { // phpcs:ignore WordPress.Security.NonceVerification.Recommended
$dismissed[] = 'perflab-admin-pointer';
update_user_meta( $current_user, 'dismissed_wp_pointers', implode( ',', $dismissed ) );
}

return;
}

Expand All @@ -86,8 +95,7 @@ function perflab_admin_pointer( $hook_suffix ) {
return;
}

$current_user = get_current_user_id();
$dismissed = explode( ',', (string) get_user_meta( $current_user, 'dismissed_wp_pointers', true ) );
$dismissed = explode( ',', (string) get_user_meta( $current_user, 'dismissed_wp_pointers', true ) );

if ( in_array( 'perflab-admin-pointer', $dismissed, true ) ) {
return;
Expand Down