Skip to content

Do not show admin pointer on the Performance screen and dismiss the pointer when visited #1147

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 12 commits into from
Apr 19, 2024
Merged

Do not show admin pointer on the Performance screen and dismiss the pointer when visited #1147

merged 12 commits into from
Apr 19, 2024

Conversation

@Ellusu
Copy link
Contributor

@Ellusu Ellusu commented Apr 16, 2024 •
edited by westonruter
Loading

Summary

Fixes: #1135

Relevant technical choices

I added the possibility to set the value of dismissed_wp_pointers at the beginning of the function if we are already in the plugin settings page.

I had to set $current_user at the beginning of the function

@github-actions
Copy link

github-actions bot commented Apr 16, 2024 •
edited
Loading

The following accounts have interacted with this PR and/or linked issues. I will continue to update these lists as activity occurs. You can also manually ask me to refresh this list by adding the props-bot label.

If you're merging code through a pull request on GitHub, copy and paste the following into the bottom of the merge commit message.

Co-authored-by: Ellusu <matteoenna@git.wordpress.org>
Co-authored-by: mukeshpanchal27 <mukesh27@git.wordpress.org>
Co-authored-by: adamsilverstein <adamsilverstein@git.wordpress.org>
Co-authored-by: westonruter <westonruter@git.wordpress.org>

To understand the WordPress project's expectations around crediting contributors, please review the Contributor Attribution page in the Core Handbook.

@Ellusu Ellusu mentioned this pull request Apr 16, 2024
Closed
mukeshpanchal27
mukeshpanchal27 reviewed Apr 16, 2024
View reviewed changes
Copy link
Member

@mukeshpanchal27 mukeshpanchal27 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks @Ellusu, Left some initial feedback for PHPCS fix.

@mukeshpanchal27 mukeshpanchal27 added [Type] Bug An existing feature is broken no milestone PRs that do not have a defined milestone for release [Plugin] Performance Lab Issue relates to work in the Performance Lab Plugin only labels Apr 16, 2024
Ellusu and others added 3 commits April 16, 2024 18:31
@Ellusu @mukeshpanchal27
Update includes/admin/load.php
587f706 
Co-authored-by: Mukesh Panchal <mukeshpanchal27@users.noreply.github.com>
@Ellusu @mukeshpanchal27
Update includes/admin/load.php
3809b71 
Co-authored-by: Mukesh Panchal <mukeshpanchal27@users.noreply.github.com>
@Ellusu @mukeshpanchal27
Update includes/admin/load.php
e381c65 
Co-authored-by: Mukesh Panchal <mukeshpanchal27@users.noreply.github.com>
adamsilverstein
adamsilverstein reviewed Apr 16, 2024
View reviewed changes
adamsilverstein
adamsilverstein reviewed Apr 16, 2024
View reviewed changes
@adamsilverstein
Copy link
Member

adamsilverstein commented Apr 16, 2024

Thanks @Ellusu - left a couple of suggestions.

@westonruter westonruter added this to the performance-lab 3.1.0 milestone Apr 16, 2024
Ellusu and others added 4 commits April 17, 2024 05:40
@Ellusu @adamsilverstein
Update includes/admin/load.php
15eb800 
Co-authored-by: Adam Silverstein <adamsilverstein@earthboundhosting.com>
@Ellusu
Update load.php
b46427f
@Ellusu
Update load.php
28f8732
@Ellusu
Update load.php
f0adcb1
westonruter
westonruter reviewed Apr 17, 2024
View reviewed changes
@Ellusu @westonruter
Update includes/admin/load.php
3f1f6cc 
Co-authored-by: Weston Ruter <westonruter@google.com>
westonruter
westonruter approved these changes Apr 17, 2024
View reviewed changes
Copy link
Member

@westonruter westonruter left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Works for me!

Before:

Screen.recording.2024-04-17.14.32.10.webm

After:

Screen.recording.2024-04-17.14.33.11.webm

@westonruter westonruter removed the no milestone PRs that do not have a defined milestone for release label Apr 17, 2024
mukeshpanchal27
mukeshpanchal27 requested changes Apr 18, 2024
View reviewed changes
Copy link
Member

@mukeshpanchal27 mukeshpanchal27 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks, @Ellusu, for the update. I left some feedback for adjustments to the conditions. Other than that, it looks solid to me.

mukeshpanchal27
mukeshpanchal27 approved these changes Apr 19, 2024
View reviewed changes
Copy link
Member

@mukeshpanchal27 mukeshpanchal27 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks @Ellusu for the updates. The changes look good to me.

@mukeshpanchal27 mukeshpanchal27 merged commit 9c15fa0 into WordPress:trunk Apr 19, 2024
@westonruter westonruter changed the title Do not show on the settings page and dismiss the pointer Do not show admin pointer on the Performance screen and dismiss the pointer when visited May 17, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@adamsilverstein adamsilverstein adamsilverstein left review comments

@westonruter westonruter westonruter approved these changes

@mukeshpanchal27 mukeshpanchal27 mukeshpanchal27 approved these changes

Assignees

No one assigned

Labels

[Plugin] Performance Lab Issue relates to work in the Performance Lab Plugin only [Type] Bug An existing feature is broken

Projects

None yet

Milestone

performance-lab 3.1.0

Development

Successfully merging this pull request may close these issues.

Setting screen tooltip should go away after visiting the settings page

4 participants

@Ellusu @adamsilverstein @westonruter @mukeshpanchal27