Merge trunk into feature/image-loading-optimization by westonruter · Pull Request #1063 · WordPress/performance

westonruter · 2024-03-19T16:36:33Z

Note that this fixes merge conflicts. Pay special attention to changes in these files:

        both modified:   .github/CODEOWNERS
        both modified:   .github/workflows/deploy-dotorg.yml
        both modified:   .github/workflows/deploy-standalone-plugins.yml
        deleted by them: .github/workflows/php-test-standalone-plugins.yml
        both modified:   .wp-env.json
        both modified:   composer.json
        both modified:   load.php
        both modified:   package-lock.json
        both modified:   package.json
        both modified:   phpunit.xml.dist
        both modified:   plugins.json
        both modified:   tests/plugins/speculation-rules/speculation-rules-test.php
        both added:      webpack.config.js

Diff with trunk: trunk...merge/trunk-into-image-loading-optimization

Co-authored-by: Weston Ruter <westonruter@google.com>

…onger relevant.

…ludes Move `admin` to `includes` directory

Bump minimum required WP version to 6.4

Fix standalone plugin versions and changelogs Co-authored-by: felixarntz <flixos90@git.wordpress.org> Co-authored-by: thelovekesh <thelovekesh@git.wordpress.org> Co-authored-by: westonruter <westonruter@git.wordpress.org>

… merge/trunk-into-image-loading-optimization

… merge/trunk-into-image-loading-optimization * 'trunk' of https://github.com/WordPress/performance: Bump Embed Optimizer required WP version to 6.4. Fix other standalone plugin versions with 6.4 bump. Fix Speculation Rules version and changelog.

Remove workflow to test standalone plugins built from modules as no longer relevant Co-authored-by: felixarntz <flixos90@git.wordpress.org> Co-authored-by: thelovekesh <thelovekesh@git.wordpress.org> Co-authored-by: westonruter <westonruter@git.wordpress.org>

Support changing autoload value for largest autoloaded options in Site Health check Co-authored-by: mukeshpanchal27 <mukesh27@git.wordpress.org> Co-authored-by: westonruter <westonruter@git.wordpress.org> Co-authored-by: felixarntz <flixos90@git.wordpress.org> Co-authored-by: swissspidy <swissspidy@git.wordpress.org>

… merge/trunk-into-image-loading-optimization * 'trunk' of https://github.com/WordPress/performance: Remove workflow to test standalone plugins built from modules as no longer relevant. Remove WP 6.3 from workflow Add unit test Apply suggestions from code review Update approach for modified option Change update option logic Minor adjustments Update parameter name Fix lint Apply suggestions from code review Use action URL approach Use button instead a tag Ensure function returns string Address review feedbacks Update since POC

…to-image-loading-optimization

westonruter · 2024-03-21T19:07:26Z

@westonruter Is this urgent? Otherwise I'd suggest to wait until you can include #1060 in this as well.

@felixarntz Now up to date with trunk as of this moment with the many PRs that were just merged.

felixarntz

@westonruter With all the merge conflicts, this is difficult to review.

Looking at trunk...merge/trunk-into-image-loading-optimization, I am especially curious about whether the build process is handled efficiently here and whether it needs to run in all the instances where it appears to be run in the feature branch (as far as I know, only optimization-detective requires a build process at this point because of web-vitals).

I'm not opposed to blindly approving this to unblock the work, but I would probably raise the same question once an actual PR from the feature branch to trunk would exist, so doesn't hurt figuring this out already :)

westonruter · 2024-03-21T19:59:25Z

@felixarntz yes, it is difficult to review.

Looking at trunk...merge/trunk-into-image-loading-optimization, I am especially curious about whether the build process is handled efficiently here and whether it needs to run in all the instances where it appears to be run in the feature branch (as far as I know, only optimization-detective requires a build process at this point because of web-vitals).

Of the 4 instances, and @thelovekesh would be best to speak to this, it could possibly be omitted from:

performance/.github/workflows/php-test.yml

Lines 65 to 66 in efb7c1e

    
           - name: Build assets 
        
             run: npm run build

and

performance/.github/workflows/deploy-dotorg.yml

Lines 23 to 24 in efb7c1e

    
           - name: Build assets 
        
             run: npm run build

Since the Performance Lab plugin doesn't currently require assets to be built.

But it would definitely need to be present in the two other locations, since it is specifically for the standalone plugins, including Optimization Detective and (soon Web Worker Offloading):

performance/.github/workflows/php-test-plugins.yml

Lines 64 to 65 in efb7c1e

    
           - name: Build assets 
        
             run: npm run build

and

performance/.github/workflows/deploy-standalone-plugins.yml

Lines 37 to 38 in efb7c1e

    
           - name: Build assets 
        
             run: npm run build

Maybe we merge this now and then get confirmation when merging into trunk?

felixarntz

Approving to unblock this. Let's make sure to iron out the workflow changes before trunk merge though. This kind of change that affects all other plugins too needs to be carefully evaluated.

adamsilverstein and others added 30 commits November 22, 2023 08:30

Missing file doc comment (Squiz.Commenting.FileComment.Missing)

2fc3745

Add oEmbed Optimize module

557933b

resore composer.lock

13308cd

cleanup

d65e170

improve docblocks

aaeb1be

improve docblocks 2

4001a0a

Process oEmbeds with WP_HTML_Tag_Processor

21f2908

Correct namespace prefix

1ed01e0

remove unused observer parameter

4ce1610

single WP_HTML_Tag_Processor loop

9eab381

remove extraneous is_string check

3701f2d

add translations

b96f6f6

Update modules/js-and-css/optimize-oembeds/hooks.php

3fdfdc2

Co-authored-by: Weston Ruter <westonruter@google.com>

Update modules/js-and-css/optimize-oembeds/hooks.php

0405547

Co-authored-by: Weston Ruter <westonruter@google.com>

Merge branch 'trunk' into add/optimize-oembeds

333179f

Update modules/js-and-css/optimize-oembeds/hooks.php

8f64e33

Co-authored-by: Weston Ruter <westonruter@google.com>

refine logic for iframe and script lazy loading

3c03658

Merge branch 'trunk' into add/optimize-oembeds

d5532cd

remove duplicate line

c3f54a7

Update modules/js-and-css/optimize-oembeds/hooks.php

5995820

Co-authored-by: Weston Ruter <westonruter@google.com>

Update modules/js-and-css/optimize-oembeds/hooks.php

1408cce

Co-authored-by: Weston Ruter <westonruter@google.com>

Update modules/js-and-css/optimize-oembeds/hooks.php

8a935a2

Co-authored-by: Weston Ruter <westonruter@google.com>

Update modules/js-and-css/optimize-oembeds/hooks.php

3b76392

Co-authored-by: Weston Ruter <westonruter@google.com>

Update modules/js-and-css/optimize-oembeds/hooks.php

bbc8c4a

Co-authored-by: Weston Ruter <westonruter@google.com>

Update modules/js-and-css/optimize-oembeds/hooks.php

c5489be

Co-authored-by: Weston Ruter <westonruter@google.com>

Update modules/js-and-css/optimize-oembeds/hooks.php

db2fa87

Co-authored-by: Weston Ruter <westonruter@google.com>

Update modules/js-and-css/optimize-oembeds/hooks.php

c9ad936

Co-authored-by: Weston Ruter <westonruter@google.com>

Update modules/js-and-css/optimize-oembeds/hooks.php

d28a02e

Co-authored-by: Weston Ruter <westonruter@google.com>

Update modules/js-and-css/optimize-oembeds/hooks.php

3ed4911

Co-authored-by: Weston Ruter <westonruter@google.com>

Merge branch 'trunk' into add/optimize-oembeds

3dc5ef5

Felix Arntz and others added 15 commits March 21, 2024 09:42

Remove workflow to test standalone plugins built from modules as no l…

bf2757d

…onger relevant.

Update path to admin files

ac7172e

Remove admin directory from PHPStan config

949c6c5

Merge branch 'trunk' into enhancement/move-admin-to-includes

1059283

Fix Speculation Rules version and changelog.

07c0b8f

Merge pull request #1072 from WordPress/enhancement/move-admin-to-inc…

84762da

…ludes Move `admin` to `includes` directory

Merge branch 'trunk' into fix/speculation-rules-version

05a52b3

Fix other standalone plugin versions with 6.4 bump.

03e8a96

Bump Embed Optimizer required WP version to 6.4.

5e43969

Merge branch 'trunk' into fix/889-update-autoload

c5f772e

Merge branch 'trunk' into remove/test-standalone-plugins

1b6e315

Merge pull request #1076 from WordPress/bump/embed-optimizer-wp-64

90ec41a

Bump minimum required WP version to 6.4

Merge branch 'trunk' of https://github.com/WordPress/performance into…

2f78d6b

… merge/trunk-into-image-loading-optimization

westonruter requested review from joemcgill, pbearne and spacedmonkey as code owners March 21, 2024 18:35

westonruter and others added 4 commits March 21, 2024 11:40

Merge branch 'feature/image-loading-optimization' into merge/trunk-in…

efb7c1e

…to-image-loading-optimization

felixarntz reviewed Mar 21, 2024

View reviewed changes

felixarntz approved these changes Mar 21, 2024

View reviewed changes

westonruter merged commit 0f5f68d into feature/image-loading-optimization Mar 21, 2024

westonruter deleted the merge/trunk-into-image-loading-optimization branch March 21, 2024 21:42

westonruter mentioned this pull request Mar 22, 2024

Merge Optimization Detective into trunk #1079

Merged

2 tasks

thelovekesh mentioned this pull request Mar 22, 2024

Update Optimization Detective plugin build process #1080

Merged

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Merge trunk into feature/image-loading-optimization#1063

Merge trunk into feature/image-loading-optimization#1063
westonruter merged 233 commits intofeature/image-loading-optimizationfrom
merge/trunk-into-image-loading-optimization

westonruter commented Mar 19, 2024 •

edited

Loading

Uh oh!

westonruter commented Mar 21, 2024

Uh oh!

felixarntz left a comment

Uh oh!

westonruter commented Mar 21, 2024

Uh oh!

felixarntz left a comment

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

7 participants

Conversation

westonruter commented Mar 19, 2024 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

westonruter commented Mar 21, 2024

Uh oh!

felixarntz left a comment

Choose a reason for hiding this comment

Uh oh!

westonruter commented Mar 21, 2024

Uh oh!

felixarntz left a comment

Choose a reason for hiding this comment

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

7 participants

westonruter commented Mar 19, 2024 •

edited

Loading