Skip to content

Add link to WebP settings to plugins table#1036

Merged
westonruter merged 8 commits intoWordPress:trunkfrom
ValeriiVasyliev:feature/webp-uploads-admin-settings-link
Mar 7, 2024
Merged

Add link to WebP settings to plugins table#1036
westonruter merged 8 commits intoWordPress:trunkfrom
ValeriiVasyliev:feature/webp-uploads-admin-settings-link

Conversation

@ValeriiVasyliev
Copy link
Copy Markdown
Contributor

@ValeriiVasyliev ValeriiVasyliev commented Mar 7, 2024

Fixes #1016

Relevant technical choices

I added a Settings link to the WebP Uploads plugin action links for better discoverability, using the plugin_action_links filter and directing users to the WebP settings in the Media section.

Checklist

  • PR has either [Focus] or Infrastructure label.
  • PR has a [Type] label.
  • PR has a milestone or the no milestone label.

@github-actions
Copy link
Copy Markdown

github-actions bot commented Mar 7, 2024

The following accounts have interacted with this PR and/or linked issues. I will continue to update these lists as activity occurs. You can also manually ask me to refresh this list by adding the props-bot label.

If you're merging code through a pull request on GitHub, copy and paste the following into the bottom of the merge commit message.

Co-authored-by: ValeriiVasyliev <gratta@git.wordpress.org>
Co-authored-by: westonruter <westonruter@git.wordpress.org>
Co-authored-by: mukeshpanchal27 <mukesh27@git.wordpress.org>
Co-authored-by: adamsilverstein <adamsilverstein@git.wordpress.org>

To understand the WordPress project's expectations around crediting contributors, please review the Contributor Attribution page in the Core Handbook.

@westonruter westonruter added [Focus] Images [Plugin] Modern Image Formats Issues for the Modern Image Formats plugin (formerly WebP Uploads) labels Mar 7, 2024
@westonruter westonruter added this to the PL Plugin 3.0.0 milestone Mar 7, 2024
@westonruter westonruter added the [Type] Enhancement A suggestion for improvement of an existing feature label Mar 7, 2024
@westonruter
Copy link
Copy Markdown
Member

Thank you! Could you fix the PHP formatting issues being reported by PHPCS by running: npm run format-php?

@ValeriiVasyliev
Copy link
Copy Markdown
Contributor Author

Hey @westonruter . Done

ValeriiVasyliev and others added 3 commits March 7, 2024 13:45
Co-authored-by: Weston Ruter <westonruter@google.com>
Co-authored-by: Weston Ruter <westonruter@google.com>
Co-authored-by: Weston Ruter <westonruter@google.com>
@mukeshpanchal27
Copy link
Copy Markdown
Member

Nice work @ValeriiVasyliev 🎉

Copy link
Copy Markdown
Member

@adamsilverstein adamsilverstein left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice work!

ValeriiVasyliev and others added 3 commits March 7, 2024 14:29
Co-authored-by: Weston Ruter <westonruter@google.com>
Co-authored-by: Mukesh Panchal <mukeshpanchal27@users.noreply.github.com>
Co-authored-by: Mukesh Panchal <mukeshpanchal27@users.noreply.github.com>
@westonruter westonruter merged commit ca48fb7 into WordPress:trunk Mar 7, 2024
@felixarntz felixarntz changed the title issue #1016 - Settings link is missing from WebP Uploads plugin actio… Add link to WebP settings to plugins table Mar 7, 2024
mukeshpanchal27 added a commit that referenced this pull request Mar 8, 2024
Add changelog entry for #1036 to WebP Uploads readme
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

[Plugin] Modern Image Formats Issues for the Modern Image Formats plugin (formerly WebP Uploads) [Type] Enhancement A suggestion for improvement of an existing feature

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Settings link is missing from WebP Uploads plugin action links

6 participants