Skip to content

Fix incorrect usage of Site Health checks color field #471

Closed
Closed
Fix incorrect usage of Site Health checks color field#471
Labels
[Type] BugAn existing feature is broken
Milestone
1.4.0

Description

@felixarntz
felixarntz
opened on Aug 12, 2022

Bug Description

See WordPress/wordpress-develop#2890 (comment): Several of our current Site Health check modules set the color based on the status of the check. However, that is not how the color should be used. Instead, it should be based on what area it applies to (in our case probably always Performance, for which WordPress core uses blue).

cc @manuelRod @tillkruss

Activity

  1. felixarntz
    added
    [Type] BugAn existing feature is broken
    [Focus] Site Health
    Needs DevAnything that requires development (e.g. a pull request)
    [Module] Audit Enqueued Assets
    [Module] Persistent Object Cache
    [Module] Audit Autoloaded Options
    [Module] Audit Full Page Cache
    on Aug 12, 2022
  2. felixarntz
    added this to the 1.4.0 milestone on Aug 12, 2022
  3. felixarntz
    self-assigned this
    on Aug 12, 2022
  4. felixarntz
    added
    Needs Review
    and removed
    Needs DevAnything that requires development (e.g. a pull request)
    on Aug 12, 2022
  5. felixarntz
    removed their assignment
    on Aug 12, 2022

  6. felixarntz commented on Aug 14, 2022

    @felixarntz
    felixarntz
    on Aug 14, 2022
    MemberAuthor

    Fixed by #472

  7. felixarntz
    closed this as completedon Aug 14, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Metadata

Metadata

Assignees

No one assigned

    Labels

    [Type] BugAn existing feature is broken

    Type

    No type

    Projects

    No projects

      Milestone

      Relationships

      None yet

      Development

      No branches or pull requests

      Issue actions