Repository navigation
Thumbnails not converted to webp since update 1.2.0 #395
Description
Hello, since update 1.2.0, my different thumbnail sizes are not automatically converted to webp. The options are still checked in settings, and it worked before.
I'm using Real Thumbnail Generator to generate several thumbnails on each upload, and it worked fine with performance.
Activity
Joaojack commentedon Jun 27, 2022
My original picture is correctly converted (apple.webp), but the generated thumbnails (apple-large.jpg, apple-thumbnail.jpg) were not
Joaojack commentedon Jun 29, 2022
@mukeshpanchal27 if you need any precisions on my issue don't hesitate to ask me, thanks !
mukeshpanchal27 commentedon Jun 29, 2022
@Joaojack Thanks for reporting the bug. I recreated it in the
1.2.0version using the free Real Thumbnail Generator plugin and the Regenerate Thumbnails plugin.It was related to Avoid overwriting existing WebP files when creating WebP images.
cc @felixarntz
felixarntz commentedon Jul 13, 2022
@mukeshpanchal27 @Joaojack I left a reply in #422 (comment), this issue definitely needs some further thought. We cannot risk overwriting files that may be used in other images, so as long as we are unable to know whether an existing file belonged to the same attachment, we cannot move forward here. Unfortunately there is no straightforward fix for this which wouldn't introduce a bug that's worse than this one.
I'm still curious why the old
sourcesaren't available when regenerating files for an image. Do the regenerate images plugins completely delete the image's attachment metadata before regenerating files for it? 🤔Joaojack commentedon Jul 13, 2022
felixarntz commentedon Jul 13, 2022
@Joaojack Before there was another bug #359, and when that was fixed, we introduced the bug you encountered here. The problem of addressing both bugs at the same time is quite complex, so this will require more exploration from an engineering perspective.
While the bug in #359 is quite specific, it unfortunately is the more severe bug (accidentally mixing up image files with another attachment), so we also cannot just revert the fix.
We will have to look into this problem further.
Joaojack commentedon Jul 14, 2022
Thank you @felixarntz for this answer. Is there any way for me to download the previous version ? I've developed a whole vue frontend calling webp versions for each thumbnail and everything is broken since the update.
mukeshpanchal27 commentedon Jul 14, 2022
@Joaojack You can download the previous version of the plugin from the WordPress.org website: https://wordpress.org/plugins/performance-lab/advanced/ at the bottom.
Please download the 1.1.0 version here: https://downloads.wordpress.org/plugin/performance-lab.1.1.0.zip
adamsilverstein commentedon Jul 19, 2022
Noting that in the core patch, we took the approach of adding the original file extension as a suffix when building the alternate mime filenames which neatly avoids the name conflict in the first place (cat.jpeg becomes cat-jpeg.wep, cat.jpg becomes cat-jpg.webp).
felixarntz commentedon Jul 19, 2022
@mukeshpanchal27 Would you mind reviewing the above implementation from the core patch? It would be great to find a way to bring the same enhancement to the Performance Lab's WebP module implementation so that we can fix this issue by generally avoiding conflicts.
mukeshpanchal27 commentedon Jul 20, 2022
Yes. Let me review the core patch.