WebP images not deleted when saved in backend after edit #375

Activity

1. mxbclang

   added

   [Focus] Images

   on Jun 15, 2022
2. mxbclang commented on Jun 15, 2022

   

   mxbclang

   on Jun 15, 2022

   Contributor

   More actions

   @mehulkaklotar Nice catch! @felixarntz @adamsilverstein Can you please take a look at this and let me know if this is expected behavior and/or something that we should address sooner than later?
3. mxbclang

   added

   no milestonePRs that do not have a defined milestone for releasePRs that do not have a defined milestone for release

   [Type] BugAn existing feature is brokenAn existing feature is broken

   [Module] WebP Support

   on Jun 15, 2022
4. felixarntz commented on Jun 15, 2022

   

   felixarntz

   on Jun 15, 2022

   Member

   More actions

   @mehulkaklotar Good catch indeed! I can confirm this is missing from our implementation. We should add support for deleting any backed up sources to our webp_uploads_remove_sources_files() function. It needs to cover:

   • Delete the sources files for each sizes within _wp_attachment_backup_sizes.
   • Delete the sources files from _wp_attachment_backup_sources.
5. felixarntz

   added

   Needs DevAnything that requires development (e.g. a pull request)Anything that requires development (e.g. a pull request)

   and removed

   no milestonePRs that do not have a defined milestone for releasePRs that do not have a defined milestone for release

   on Jun 15, 2022
6. felixarntz

   added this to the 1.3.0 milestone on Jun 15, 2022
7. felixarntz

   added

   [Plugin] Modern Image FormatsFormerly WebP Uploads [slug: webp-uploads]Formerly WebP Uploads [slug: webp-uploads]

   and removed

   [Module] WebP Support

   on Jun 16, 2022
8. mehulkaklotar

   self-assigned this

   on Jun 24, 2022
9. mehulkaklotar

   removed

   Needs DevAnything that requires development (e.g. a pull request)Anything that requires development (e.g. a pull request)

   on Jun 27, 2022
10. mehulkaklotar

    added 5 commits that reference this issue on Jul 1, 2022

    #375 remove backup sizes files when deleted attachment

    b609f0e

    #375 remove backup sources files when deleted attachment

    f51ebcf

    #375 test case to prove that webp versions of files not exist when de…

    ...

    fcbd062

    #375 test function comment fix

    e708b70

    #375 - tests: asserts for not empty array added & attachment meta ass…

    ...

    5345210
11. felixarntz

    closed this as completedin #411on Jul 7, 2022