Merge pull request #287 from WordPress/enhancement/smaller-image-file-optin

felixarntz · web-flow · commit faa8156b41d9 · 2022-04-14T11:27:58.000-05:00
Introduce `webp_uploads_prefer_smaller_image_file` filter allowing to opt in to preferring the smaller image file
diff --git a/modules/images/webp-uploads/load.php b/modules/images/webp-uploads/load.php
@@ -599,6 +599,22 @@ function webp_uploads_img_tag_update_mime_type( $image, $context, $attachment_id
 	 */
 	$target_mimes = apply_filters( 'webp_uploads_content_image_mimes', array( 'image/webp', 'image/jpeg' ), $attachment_id, $context );
 
+	/**
+	 * Filters whether the smaller image should be used regardless of which MIME type is preferred overall.
+	 *
+	 * This is disabled by default only because it is not part of the current WordPress core feature proposal.
+	 *
+	 * By enabling this, the plugin will compare the image file sizes and prefer the smaller file regardless of MIME
+	 * type.
+	 *
+	 * @since n.e.x.t
+	 *
+	 * @param bool $prefer_smaller_image_file Whether to prefer the smaller image file.
+	 */
+	if ( apply_filters( 'webp_uploads_prefer_smaller_image_file', false ) ) {
+		$target_mimes = webp_uploads_get_mime_types_by_filesize( $target_mimes, $attachment_id );
+	}
+
 	$target_mime = null;
 	foreach ( $target_mimes as $mime ) {
 		if ( isset( $metadata['sources'][ $mime ] ) ) {
@@ -933,4 +949,3 @@ function( $a, $b ) {
 	// Create an array of available mime types ordered by smallest filesize.
 	return array_keys( $sources );
 }
-add_filter( 'webp_uploads_content_image_mimes', 'webp_uploads_get_mime_types_by_filesize', 10, 2 );
