Revert param name change

westonruter · westonruter · commit bfb9e116a6c3 · 2024-09-27T09:59:15.000-07:00
diff --git a/plugins/web-worker-offloading/hooks.php b/plugins/web-worker-offloading/hooks.php
@@ -79,15 +79,15 @@ function wwo_register_default_scripts( WP_Scripts $scripts ): void {
  *
  * @since 0.1.0
  *
- * @param string[]|mixed $to_do An array of enqueued script dependency handles.
+ * @param string[]|mixed $script_handles An array of enqueued script dependency handles.
  * @return string[] Script handles.
  */
-function wwo_filter_print_scripts_array( $to_do ): array {
+function wwo_filter_print_scripts_array( $script_handles ): array {
 	$scripts = wp_scripts();
-	foreach ( (array) $to_do as $handle ) {
+	foreach ( (array) $script_handles as $handle ) {
 		if ( true === (bool) $scripts->get_data( $handle, 'worker' ) ) {
 			$scripts->set_group( 'web-worker-offloading', false, 0 ); // Try to print in the head.
-			array_unshift( $to_do, 'web-worker-offloading' );
+			array_unshift( $script_handles, 'web-worker-offloading' );
 
 			// TODO: This should be reconsidered because scripts needing to be offloaded will often have after scripts. See <https://github.com/WordPress/performance/pull/1497/files#r1733538721>.
 			if ( false === wp_scripts()->get_data( $handle, 'strategy' ) ) {
@@ -96,7 +96,7 @@ function wwo_filter_print_scripts_array( $to_do ): array {
 			}
 		}
 	}
-	return $to_do;
+	return $script_handles;
 }
 add_filter( 'print_scripts_array', 'wwo_filter_print_scripts_array' );
 

Original file line number	Diff line number	Diff line change
`@@ -79,15 +79,15 @@ function wwo_register_default_scripts( WP_Scripts $scripts ): void {`
`79`	`79`	`*`
`80`	`80`	`* @since 0.1.0`
`81`	`81`	`*`
`82`		`- * @param string[]\|mixed $to_do An array of enqueued script dependency handles.`
	`82`	`+ * @param string[]\|mixed $script_handles An array of enqueued script dependency handles.`
`83`	`83`	`* @return string[] Script handles.`
`84`	`84`	`*/`
`85`		`-function wwo_filter_print_scripts_array( $to_do ): array {`
	`85`	`+function wwo_filter_print_scripts_array( $script_handles ): array {`
`86`	`86`	`$scripts = wp_scripts();`
`87`		`- foreach ( (array) $to_do as $handle ) {`
	`87`	`+ foreach ( (array) $script_handles as $handle ) {`
`88`	`88`	`if ( true === (bool) $scripts->get_data( $handle, 'worker' ) ) {`
`89`	`89`	`$scripts->set_group( 'web-worker-offloading', false, 0 ); // Try to print in the head.`
`90`		`- array_unshift( $to_do, 'web-worker-offloading' );`
	`90`	`+ array_unshift( $script_handles, 'web-worker-offloading' );`
`91`	`91`
`92`	`92`	`// TODO: This should be reconsidered because scripts needing to be offloaded will often have after scripts. See <https://github.com/WordPress/performance/pull/1497/files#r1733538721>.`
`93`	`93`	`if ( false === wp_scripts()->get_data( $handle, 'strategy' ) ) {`
`@@ -96,7 +96,7 @@ function wwo_filter_print_scripts_array( $to_do ): array {`
`96`	`96`	`}`
`97`	`97`	`}`
`98`	`98`	`}`
`99`		`- return $to_do;`
	`99`	`+ return $script_handles;`
`100`	`100`	`}`
`101`	`101`	`add_filter( 'print_scripts_array', 'wwo_filter_print_scripts_array' );`
`102`	`102`