Repository navigation
Pass the GitHub token to the docs-check CI steps - #5641
Merged
Merged
Conversation
The generated-documentation checks for the catalog, API and frontend run prettier through pre-commit, and the `precommit` recipe downloads pre-commit from the GitHub releases API first. Those steps did not set GITHUB_TOKEN, so the download ran unauthenticated and hit the per-IP rate limit whenever many jobs ran at once. The recipe swallows that failure, prettier never runs, and the check fails on formatting differences in the generated file. The lint job already passes the token; do the same here. Co-Authored-By: Claude Mythos 5.1 <noreply@anthropic.com>
obenland
requested review from
dhruvkb and
krysal
and removed request for
a team
October 13, 2026 16:18
Latest k6 run output1Footnotes
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes
Intermittent failures of "Run catalog checks" and "Run Nuxt checks (test_media_props)", seen today on #5639 and #5640.
Description
The generated-documentation checks (
catalog/generate-docs,api/generate-docs,frontend/generate-docs) run prettier on the generated file throughjust lint, which first runs theprecommitrecipe. That recipe fetches the latest pre-commit release from the GitHub API withcurl, authenticated only whenGITHUB_TOKENis set. These steps never set it, so the request was unauthenticated and subject to the per-IP rate limit shared by hosted runners. When many jobs ran at once (today's burst of Renovate PRs), the request failed, the|| truein the recipe hid it, prettier never ran, and the check failed on the formatting differences between the raw generated file and the committed one.The evidence: on the failing runs the "Running linting..." step took 0.16 to 1 second; on passing runs it takes 6 to 13 seconds. The "Lint files" job already passes the token for the same reason. This does the same for the three docs-check steps.
Testing Instructions
CI. The catalog, API and Nuxt check jobs run on this PR.
Checklist
Update index.md).main) or a parent feature branch.ov just catalog/generate-docsfor catalogPRs) or the media properties generator (
ov just catalog/generate-docs media-propsfor the catalog or
ov just api/generate-docsfor the API) where applicable.Developer Certificate of Origin
Developer Certificate of Origin
🤖 Generated with Claude Code