Skip to content

Update vulnerable JS dependencies in the pnpm lockfile - #5630

Merged
obenland merged 2 commits into
mainfrom
fix/security-dependency-updates
Oct 13, 2026
Merged

obenland merged 2 commits into
mainfrom
fix/security-dependency-updates

Conversation

@obenland

Copy link
Copy Markdown
Member

Fixes

Supersedes #5569, #5558, #5553, #5535, #5533, #5531, #5530 and #5511.

Description

Applies the dependency updates that Renovate's open [SECURITY] PRs were supposed to make. Those PRs all carry an identical lockfile diff that leaves the vulnerable versions in place, because the Renovate version in use updates pnpm lockfiles without --recursive (see #5628 for the fix to Renovate itself).

Package Before After Advisories
axios 1.8.2 1.13.5 CVE-2025-58754, CVE-2026-25639
js-yaml 4.1.0 4.3.2 CVE-2025-64718
vite 6.0.11 6.4.4 CVE-2025-30208, CVE-2025-31125, CVE-2025-31486, CVE-2025-32395
rollup 4.31.0 4.64.6 CVE-2026-27606
glob 11.0.0 11.1.0 CVE-2025-64756
vue-i18n, @intlify/core, @intlify/core-base 11.1.2 / 11.0.1 11.1.10 CVE-2025-53892

Nuxt (#5534) is deliberately left at 3.15.1. Nuxt 3.17 and later move to unhead v2 and a newer nitropack, which breaks type checking in nuxt.config.ts, app.vue, error.vue and the pages that still pass hid to useHead. That upgrade needs code changes and its own PR, and should target at least 3.21.10 since newer Nuxt advisories (GHSA-934w-87qh-qr26, GHSA-c9cv-mq2m-ppp3, GHSA-9pgf-384g-p7mv) are fixed there rather than in 3.19.0.

The only package.json change is the root pnpm.overrides range for vite, which moves from ^6.0.11 to ^6.4.1. Without it the frontend's transitive vite resolution stays at 6.0.11 even after the update.

Generated with the repository's pinned pnpm 10.2.0:

pnpm update -r --no-save js-yaml@4.1.1 axios@1.13.5 rollup@4.59.0 vite@6.4.1 glob@11.1.0 @intlify/core@11.1.10 @intlify/core-base@11.1.10 vue-i18n@11.1.10 --lockfile-only
pnpm dedupe --lockfile-only

Testing Instructions

CI covers this. To confirm the lockfile no longer contains the vulnerable versions:

grep -cE "^  '?(axios@1\.8\.2|js-yaml@4\.1\.0|vite@6\.0\.11|rollup@4\.31\.0|glob@11\.0\.0|vue-i18n@11\.1\.2|@intlify/core(-base)?@11\.0\.1)[:(]" pnpm-lock.yaml

should print 0.

Checklist

  • My pull request has a descriptive title (not a vague title likeUpdate index.md).
  • My pull request targets the default branch of the repository (main) or a parent feature branch.
  • My commit messages follow best practices.
  • My code follows the established code style of the repository.
  • I added or updated tests for the changes I made (if applicable).
  • I added or updated documentation (if applicable).
  • I tried running the project locally and verified that there are no visible errors.
  • I ran the DAG documentation generator (ov just catalog/generate-docs for catalog
    PRs) or the media properties generator (ov just catalog/generate-docs media-props
    for the catalog or ov just api/generate-docs for the API) where applicable.

Developer Certificate of Origin

Developer Certificate of Origin
Developer Certificate of Origin
Version 1.1

Copyright (C) 2004, 2006 The Linux Foundation and its contributors.
1 Letterman Drive
Suite D4700
San Francisco, CA, 94129

Everyone is permitted to copy and distribute verbatim copies of this
license document, but changing it is not allowed.


Developer's Certificate of Origin 1.1

By making a contribution to this project, I certify that:

(a) The contribution was created in whole or in part by me and I
    have the right to submit it under the open source license
    indicated in the file; or

(b) The contribution is based upon previous work that, to the best
    of my knowledge, is covered under an appropriate open source
    license and I have the right under that license to submit that
    work with modifications, whether created in whole or in part
    by me, under the same open source license (unless I am
    permitted to submit under a different license), as indicated
    in the file; or

(c) The contribution was provided directly to me by some other
    person who certified (a), (b) or (c) and I have not modified
    it.

(d) I understand and agree that this project and the contribution
    are public and that a record of the contribution (including all
    personal information I submit with it, including my sign-off) is
    maintained indefinitely and may be redistributed consistent with
    this project or the open source license(s) involved.

🤖 Generated with Claude Code

Renovate's security PRs for these packages never changed the resolved
versions, because the Renovate version in use updated the lockfile from
the workspace root without `--recursive`. Apply the updates directly:

- axios 1.8.2 -> 1.13.5 (CVE-2025-58754, CVE-2026-25639)
- js-yaml 4.1.0 -> 4.3.2 (CVE-2025-64718)
- vite 6.0.11 -> 6.4.4 (CVE-2025-30208, CVE-2025-31125,
  CVE-2025-31486, CVE-2025-32395)
- rollup 4.31.0 -> 4.64.6 (CVE-2026-27606)
- glob 11.0.0 -> 11.1.0 (CVE-2025-64756)
- vue-i18n, @intlify/core, @intlify/core-base -> 11.1.10 (CVE-2025-53892)

The root `pnpm.overrides` range for vite moves to `^6.4.1`, since the
frontend's transitive vite resolution otherwise stays pinned at 6.0.11.
Nuxt is deliberately left at 3.15.1: 3.17+ moves to unhead v2 and a
newer nitropack, which needs code changes and belongs in its own PR.

Generated with `pnpm update -r --no-save ... --lockfile-only` followed by
`pnpm dedupe --lockfile-only`, using the repository's pinned pnpm 10.2.0.

Co-Authored-By: Claude Mythos 5.1 <noreply@anthropic.com>
@obenland obenland added 🟨 priority: medium Not blocking but should be addressed soon 💻 aspect: code Concerns the software code in the repository dependencies Pull requests that update a dependency file 🧰 goal: internal improvement Improvement that benefits maintainers, not users labels Oct 13, 2026
@obenland
obenland requested a review from a team as a code owner October 13, 2026 13:58
@obenland obenland added the 🧱 stack: frontend Related to the Nuxt frontend label Oct 13, 2026
@obenland
obenland requested review from dhruvkb and krysal and a balanced review from Copilot October 13, 2026 13:58

Copilot AI left a comment

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Copilot was unable to review this pull request because the user who requested the review has reached their quota limit.

@openverse-bot openverse-bot moved this to 👀 Needs Review in Openverse PRs Oct 13, 2026
With a single deduplicated copy of @intlify/core-base, the locale union
that @nuxtjs/i18n generates now reaches vue-i18n's `Locale` type, so
`BannerId` narrows to the locales configured for the current build. The
`types` script runs against the English-only test setup, where
`translation-ru` and `translation-ar` no longer type-check. The test only
asserts round-tripping of the array, so use ids that exist in that setup.

Co-Authored-By: Claude Mythos 5.1 <noreply@anthropic.com>
@github-actions

Copy link
Copy Markdown

Latest k6 run output1

     ✓ status was 200

     checks.........................: 100.00% ✓ 412      ✗ 0   
     data_received..................: 96 MB   399 kB/s
     data_sent......................: 131 kB  544 B/s
     http_req_blocked...............: avg=44.8µs   min=2.38µs   med=4.65µs   max=2.1ms    p(90)=153.11µs p(95)=181.85µs
     http_req_connecting............: avg=29.41µs  min=0s       med=0s       max=2.03ms   p(90)=97.6µs   p(95)=118.84µs
     http_req_duration..............: avg=168.31ms min=20.53ms  med=111.46ms max=959.9ms  p(90)=368.83ms p(95)=455.74ms
       { expected_response:true }...: avg=168.31ms min=20.53ms  med=111.46ms max=959.9ms  p(90)=368.83ms p(95)=455.74ms
   ✓ http_req_failed................: 0.00%   ✓ 0        ✗ 412 
     http_req_receiving.............: avg=174.45µs min=62.35µs  med=157.18µs max=553.71µs p(90)=261.41µs p(95)=305.73µs
     http_req_sending...............: avg=30.17µs  min=8.95µs   med=23.56µs  max=2.74ms   p(90)=30.77µs  p(95)=38.56µs 
     http_req_tls_handshaking.......: avg=0s       min=0s       med=0s       max=0s       p(90)=0s       p(95)=0s      
     http_req_waiting...............: avg=168.1ms  min=20.42ms  med=111.21ms max=959.68ms p(90)=368.58ms p(95)=455.53ms
     http_reqs......................: 412     1.709621/s
     iteration_duration.............: avg=919.39ms min=447.22ms med=975.6ms  max=1.8s     p(90)=1.19s    p(95)=1.27s   
     iterations.....................: 76      0.315367/s
     vus............................: 3       min=0      max=6 
     vus_max........................: 60      min=60     max=60

Footnotes

  1. This comment will automatically update with new output each time k6 runs for this PR ↩

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

💻 aspect: code Concerns the software code in the repository dependencies Pull requests that update a dependency file 🧰 goal: internal improvement Improvement that benefits maintainers, not users 🟨 priority: medium Not blocking but should be addressed soon 🧱 stack: frontend Related to the Nuxt frontend

Projects

Archived in project

Development

Successfully merging this pull request may close these issues.

3 participants